[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
GitHub user bzz opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/818

    ZEPPELIN-783: fix Spark download on CI

    ### What is this PR for?
    Fix Spark download on CI
   
    ### What type of PR is it?
    Hot Fix
   
    ### What is the Jira issue?
    [ZEPPELIN-783](https://issues.apache.org/jira/browse/ZEPPELIN-783)
   
    ### How should this be tested?
    CI must be green
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bzz/incubator-zeppelin ZEPPELIN-783-stable-ci-part-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #818
   
----
commit ac8ab77ffe7dc1125e9e4ca973a8af2429f0cbac
Author: Alexander Bezzubov <[hidden email]>
Date:   2016-04-06T07:21:56Z

    ZEPPELIN-783: advanced Spark download failover procedure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-206450666
 
    \cc @felixcheung for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-206639157
 
    This is fixes 2 CI https://travis-ci.org/bzz/incubator-zeppelin and https://travis-ci.org/apache/incubator-zeppelin and is ready to be merged.
   
    \cc @felixcheung @Leemoonsoo @jongyoul @prabhjyotsingh for a review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207143423
 
    Merging if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user lresende commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207145214
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207145720
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207194646
 
    Thank you for reviews!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/818


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-zeppelin pull request: ZEPPELIN-783: fix Spark download ...

yx91490
In reply to this post by yx91490
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/818#issuecomment-207239148
 
    Looks good - sorry for the delay.
    My only thought was that we should probably echo the exit code from wget if it is not zero in download_with_retry() 
       
   
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---