[GitHub] zeppelin pull request #1908: [ZEPPELIN-1976] Text-Output too large, causing ...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #1908: [ZEPPELIN-1976] Text-Output too large, causing ...

zjffdu
GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1908

    [ZEPPELIN-1976] Text-Output too large, causing crash

    ### What is this PR for?
    This PR implements interpreter output message limit.
   
    `ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` env variable or `zeppelin.interpreter.output.limit` jvm property can set limit of the interpreter output message in byte.
   
    The limit applied to only TEXT and TABLE type output, not in HTML or other types.
   
   
    ### What type of PR is it?
    Improvement
   
    ### Todos
    * [x] - Task
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1976
   
    ### How should this be tested?
   
    try to print more than the limit
    ```
    %spark
    (1 to 10000).foreach(i=>
        println(s"Print line ${i} times")
    )
    ```
   
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/1540981/22035334/6c17ff9a-dca4-11e6-89b0-51b9340856b0.png)
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1908
   
----
commit 7635c55cd75f2c4b0fc251a131308fb79a1ecff0
Author: Lee moon soo <[hidden email]>
Date:   2017-01-16T18:03:23Z

    Remove extension from webpack config for visualization bundle

commit b66558840661bac75e83a2c8d34f8d382391cdae
Author: Lee moon soo <[hidden email]>
Date:   2017-01-16T18:13:45Z

    Propagate npm install error to front-end

commit ec7baad440ef66ff4ea5c7d5da37bea4e6c430d7
Author: Lee moon soo <[hidden email]>
Date:   2017-01-17T18:49:38Z

    Truncate output

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #1908: [ZEPPELIN-1976] Text-Output too large, causing crash

zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1908
 
    Merge to master when no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #1908: [ZEPPELIN-1976] Text-Output too large, causing ...

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1908


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #1908: [ZEPPELIN-1976] Text-Output too large, causing crash

zjffdu
In reply to this post by zjffdu
Github user BruceXu1991 commented on the issue:

    https://github.com/apache/zeppelin/pull/1908
 
    This PR limit the output of paragraph in web, however it also limit the max download lines.
   
    My suggestion is to limit output of paragraph through zeppelin.interpreter.output.limit and limit the number of download lines through common.max_count.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...