[GitHub] zeppelin pull request #2250: [WIP][ZEPPELIN-2085] Interpret scala code in pa...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2250: [WIP][ZEPPELIN-2085] Interpret scala code in pa...

zjffdu
GitHub user DrIgor opened a pull request:

    https://github.com/apache/zeppelin/pull/2250

    [WIP][ZEPPELIN-2085] Interpret scala code in paste mode

    ### What is this PR for?
    Don't split scala code to lines.
   
    Interpreter code becomes more and more complicated because some lines have to be executed
    together (companion objects, etc.). And still it doesn't handle all possibilities.
   
    I propose not to split interpreter input at all.
    I checked scala repl sources: repl paste mode interpret code without splitting.
   
    ### What type of PR is it?
    [Bug Fix | Improvement]
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2085
   
    ### How should this be tested?
    Try to run several code snippets attached to jira issue.
    See also https://issues.apache.org/jira/browse/ZEPPELIN-658
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-2085

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2250
   
----
commit 8c4232439c6adad456520798f1d838f134ef310f
Author: Igor Drozdov <[hidden email]>
Date:   2017-03-20T14:16:22Z

    Interpret scala code as a single piece

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [WIP][ZEPPELIN-2085] Interpret scala code in paste mod...

zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    Using paste mode would be better. We have so many if-else code to manipulate code which is already covered by paste mode.
   
    If we evaluate using paste mode, evaluation orders will be affected. If it doesn't matter or not that important, i think it's ok to use paste mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [WIP][ZEPPELIN-2085] Interpret scala code in paste mod...

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    +1 for not splitting scala code in zeppelin side, that should be handled by scala repl.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [ZEPPELIN-2085] Interpret scala code in paste mode

zjffdu
In reply to this post by zjffdu
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    Finally done PR and travis is green


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [ZEPPELIN-2085] Interpret scala code in paste mode

zjffdu
In reply to this post by zjffdu
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    Please explain what issues I need to fix)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [ZEPPELIN-2085] Interpret scala code in paste mode

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    I think we'd better take care of the comments left.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2250: [ZEPPELIN-2085] Interpret scala code in paste m...

zjffdu
In reply to this post by zjffdu
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/2250


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2250: [ZEPPELIN-2085] Interpret scala code in paste m...

zjffdu
In reply to this post by zjffdu
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/2250

    [ZEPPELIN-2085] Interpret scala code in paste mode

    ### What is this PR for?
    Don't split scala code to lines.
   
    Interpreter code becomes more and more complicated because some lines have to be executed
    together (companion objects, etc.). And still it doesn't handle all possibilities.
   
    I propose not to split interpreter input at all.
    I checked scala repl sources: repl paste mode interpret code without splitting.
   
    ### What type of PR is it?
    [Bug Fix | Improvement]
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2085
   
    ### How should this be tested?
    Try to run several code snippets attached to jira issue.
    See also https://issues.apache.org/jira/browse/ZEPPELIN-658
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-2085

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2250
   
----
commit 4087cfe2b17fa0327c5a73d51aad44ce1e74776b
Author: Igor Drozdov <[hidden email]>
Date:   2017-03-20T14:16:22Z

    Interpret scala code as a single piece

commit 71d8eabf5811d1a6186dbdf6710536d245af4d88
Author: Igor Drozdov <[hidden email]>
Date:   2017-05-18T08:13:57Z

    Companion object definition test

commit c7e5c58d333bea498fdd9edfbe7548efd75458b3
Author: Igor Drozdov <[hidden email]>
Date:   2017-05-22T13:07:46Z

    fixup Interpret scala code as a single piece

commit 12b3d3303865da426e9759cffa90a27bef346eac
Author: Igor Drozdov <[hidden email]>
Date:   2017-06-05T09:05:01Z

    Don't use hamrest in tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2250: [ZEPPELIN-2085] Interpret scala code in paste mode

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2250
 
    I'm a bit confused because there's some unrelated changes regarding this issue. I don't know why you change zeppelin-interpreter package and why you make hash code and equals method. Can you make your changes more smaller? I think you add some minor changes regardless of this issue. Please divide those into another minor issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---