[GitHub] zeppelin pull request #2282: fix python interpreter as to use max result set...

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2282: fix python interpreter as to use max result set...

zjffdu
GitHub user paularmand opened a pull request:

    https://github.com/apache/zeppelin/pull/2282

    fix python interpreter as to use max result setting

    ### What is this PR for?
    zeppelin_python.py used a hard-coded 1000 rows limit when returning results. This PR makes sure that the interpreter retrieves the max_results from PythonInterpreter.java and that the latter retrieves this configuration from the configuration via the properties object.
   
    ### What type of PR is it?
    Bug Fix
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2447
   
    ### How should this be tested?
    + use %python interpreter
    + make a dataframe with more than a 1000 rows
    + z.show the dataframe
    + export it in csv
    + the numbers of rows should exceed 1000 rows
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paularmand/zeppelin python_interpreter_max_results

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2282
   
----
commit 507c6e88ea2e0d5410cf02c20a177b8b0e93b2f6
Author: Paul-Armand Verhaegen <[hidden email]>
Date:   2017-04-25T08:10:19Z

    fix python interpreter as to use max result setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: Fix python interpreter as to use max result setting

zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    Ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: Fix python interpreter as to use max result setting

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    ping @paularmand Can you fix the comment ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: Fix python interpreter as to use max result setting

zjffdu
In reply to this post by zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    @zjffdu Thanks for review. Added 1000 hard coded as default for now, although I believe a better solution would be to add fallbacks to a property class upfront (see https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#defaults).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: Fix python interpreter as to use max result setting

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    Thanks @paularmand LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: Fix python interpreter as to use max result setting

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    @paularmand Could you add jira to the title of your PR ? name it as `[ZEPPELIN-2447] Fix python interpreter as to use max result setting`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    Is the Jenkins failure an unrelated selenium test failure, or do I have to look into it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    ping @zjffdu Do I have to look into it the Selenium test failure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    @paularmand Selenium test is flaky, one thing left is unit test. Could you add unit test in `PythonInterpreterTest` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    @zjffdu I'll have a look. Can expect something later on this week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user paularmand commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    Pong @jongyoul . I wrote the unit test, but it is not passing on Jenkins. I have trouble setting up my local IDE to run the python tests in IntelliJ (all other tests, except the python ones, are running fine), so I'll have to dig deeper in the IDE settings. Pointers/help appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2282: [ZEPPELIN-2447] Fix python interpreter as to use max r...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2282
 
    Let me check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---