[GitHub] zeppelin pull request #2284: [ZEPPELIN-2451]: Add JDBC config option for cal...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2284: [ZEPPELIN-2451]: Add JDBC config option for cal...

zjffdu
GitHub user randerzander opened a pull request:

    https://github.com/apache/zeppelin/pull/2284

    [ZEPPELIN-2451]: Add JDBC config option for calling connection.commit after paragraph execution

    ### What is this PR for?
    Adding config for automatically calling commit after JDBC paragraph execution
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2451
   
    ### How should this be tested?
    Create property zeppelin.jdbc.autocommit with value "true" under the JDBC interpreter, run an INSERT statement against a database. The insert should be committed and should be accessible in the database.
   
    Create property zeppelin.jdbc.autocommit with value "false" under the JDBC interpreter, run an INSERT statement against a database. The insert should not be committed and will not be in the database.
   
    ### Questions:
    * Does the licenses files need update?
    No
    * Is there breaking changes for older versions?
    No
    * Does this needs documentation?
    Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/randerzander/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2284
   
----
commit 07b7a3a6461acbcbe2b06e843d23fceae33c396e
Author: Randy Gelhausen <[hidden email]>
Date:   2017-04-26T02:51:25Z

    ZEPPELIN-2451: Add JDBC config option for calling connection.commit after paragraph execution

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2284: [ZEPPELIN-2451]: Add JDBC config option for calling co...

zjffdu
Github user randerzander commented on the issue:

    https://github.com/apache/zeppelin/pull/2284
 
    Looks like recent commits conflict with this fix. I'll re-synch with master, but @Leemoonsoo any comments on the approach before I do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2284: [ZEPPELIN-2451]: Add JDBC config option for calling co...

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2284
 
    Looks like this PR changes default behavior.
   
    Previously, `connection.commit()` is executed if `connection.getAutoCommit()` is false.
    But after this patch, `connection.commit()` will be executed if `connection.getAutoCommit()` is false and `zeppelin.jdbc.autocommit` property is true.
   
    And `zeppelin.jdbc.autocommit` property is false by default.
   
    Shell we keep default behavior?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2284: [ZEPPELIN-2451]: Add JDBC config option for cal...

zjffdu
In reply to this post by zjffdu
Github user randerzander closed the pull request at:

    https://github.com/apache/zeppelin/pull/2284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2284: [ZEPPELIN-2451]: Add JDBC config option for calling co...

zjffdu
In reply to this post by zjffdu
Github user randerzander commented on the issue:

    https://github.com/apache/zeppelin/pull/2284
 
    Closed in favor of https://github.com/apache/zeppelin/pull/2396


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---