[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph

classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
GitHub user tinkoff-dwh opened a pull request:

    https://github.com/apache/zeppelin/pull/2309

    [ZEPPELIN-2482] added font size for paragraph

    ### What is this PR for?
    1. Added possibilty to change font size of paragraph text
    2. Fixed cloneParagraphAction (immediately after the cloning is incorrectly displayed a new paragraph)
    3. Fixed paragraph settings into Firefox
   
   
    ### What type of PR is it?
    Feature
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2482
   
    ### How should this be tested?
    1. Open note
    2. Add some text to paragraph
    3. Open settings of paragraph and chenge "Font size"
   
    ### Screenshots (if appropriate)
    1. Font size and clone
   
    BEFORE
    ![before_clone](https://cloud.githubusercontent.com/assets/25951039/25618618/21852dee-2f61-11e7-80f5-634320ffc1ce.gif)
   
    AFTER
    ![after_clone](https://cloud.githubusercontent.com/assets/25951039/25618637/2d8f484a-2f61-11e7-8f94-2f95026098f4.gif)
   
    2. Fix for Firefox
    BEFORE
    ![before_float_firefox](https://cloud.githubusercontent.com/assets/25951039/25618663/44c7d19e-2f61-11e7-8513-ee74eab4e8f4.png)
    AFTER
    ![after_float_firefox](https://cloud.githubusercontent.com/assets/25951039/25618677/4bf49c90-2f61-11e7-8ade-14d501a4e239.png)
   
   
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2482

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2309
   
----
commit 5e2be167d5a532e7d9522bdedee1c5cde360be66
Author: Tinkoff DWH <[hidden email]>
Date:   2017-05-02T11:18:04Z

    [ZEPPELIN-2482] font size for paragraph

commit 794bbf1b10e7926dd5917bdd727b4245630b9255
Author: Tinkoff DWH <[hidden email]>
Date:   2017-05-02T12:34:49Z

    [ZEPPELIN-2482] close settings

commit 62ef72860dde7c7b50e6b15043fea9ef38884bd9
Author: Tinkoff DWH <[hidden email]>
Date:   2017-05-02T15:32:07Z

    [ZEPPELIN-2482] font size test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    CI red -> AuthenticationIT.testGroupPermission


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    Thanks @tinkoff-dwh and nice feature!
    Let me test and come back here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    In `Font size and clone` and firefox browser case, I tested and it's work well. LGTM.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    LGTM. @1ambda Can you verify it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @tinkoff-dwh @jongyoul sorry for the late reply.
   
    I will test and comment in few hours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    This feature will be helpful when displaying in the report mode but want to increase font-size.
   
    - need to be rebased. base branch is outdated.
    - *+1* reindent DOMs and having a test
   
    LGTM. Thanks for the contribution @tinkoff-dwh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @1ambda Thanks. @tinkoff-dwh Please catch up the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @1ambda
    save changes by change font size works fine
    ![peek 2017-06-12 16-08](https://user-images.githubusercontent.com/25951039/27031450-b528e430-4f89-11e7-9d9a-045c20c4913a.gif)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @tinkoff-dwh saving works. but it's not automatically propagated to other web-browsers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @1ambda
    can you provide a link to the code where it is implemented to **colWidth**?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    I attached a GIF.
   
    ![pr2309](https://user-images.githubusercontent.com/4968473/27031707-4bf0fd5e-4fac-11e7-956c-e97308df28ad.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @tinkoff-dwh Do you still need a link? or just wanted to check the behavior?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @1ambda
    no, thx. it's clear


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    @1ambda
    done
    ![peek 2017-06-12 22-09](https://user-images.githubusercontent.com/25951039/27066470-e40958f4-501d-11e7-8f7d-4043dc75928d.gif)
   
    ci red because fall other tests (not mine)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    Looks good. I guess the failed job in https://travis-ci.org/tinkoff-dwh/zeppelin/builds/242104908 is due to a flaky test. But just to make sure, could you restart it so that CI will be green?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2309
 
    the same errors
   
    ```
    ParagraphActionsIT.testSingleDynamicFormSelectForm:624 » NoSuchElement Cannot ...
    ParagraphActionsIT.testMultipleDynamicFormsSameType:707 » NoSuchElement Cannot...
    ParagraphActionsIT.testRunOnSelectionChange:282 » NoSuchElement Cannot locate ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12