[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
   
    Highlight active line.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
   
    ### How should this be tested?
   
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
   
    ### Screenshots (if appropriate)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26278755/268ab126-3ddd-11e7-81c7-088816c7597b.png)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
   
----
commit cd896079d2e52ced4f9cfc92a1e3a0b0046f60e2
Author: 1ambda <[hidden email]>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit 7ceee46f7df29abcc7164a3ccbf2df32095e9824
Author: 1ambda <[hidden email]>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
   
    Highlight active line.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
   
    ### How should this be tested?
   
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
   
    ### Screenshots (if appropriate)
   
    ![2460_active_line](https://cloud.githubusercontent.com/assets/4968473/26279598/de38b114-3df2-11e7-9d3a-f0d4f59b8cd1.gif)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
   
----
commit 6424db580c922fac03a42620340f2239d029babe
Author: 1ambda <[hidden email]>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9
Author: 1ambda <[hidden email]>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

commit 0366948fe750478fc3c4ce946ba0e0383728fa21
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:51:03Z

    fix: Show single active line in a note

commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:55:18Z

    fix: Use blue-light color for active line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
   
    Highlight active line.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
   
    ### How should this be tested?
   
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
   
    ### Screenshots (if appropriate)
   
    ![2460_active_line](https://cloud.githubusercontent.com/assets/4968473/26279598/de38b114-3df2-11e7-9d3a-f0d4f59b8cd1.gif)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
   
----
commit 6424db580c922fac03a42620340f2239d029babe
Author: 1ambda <[hidden email]>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9
Author: 1ambda <[hidden email]>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

commit 0366948fe750478fc3c4ce946ba0e0383728fa21
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:51:03Z

    fix: Show single active line in a note

commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:55:18Z

    fix: Use blue-light color for active line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2356

    [ZEPPELIN-2460] Highlight active line in editor

    ### What is this PR for?
   
    Highlight active line.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Added ui-ace option
    * [x] - Fix css for paragraph control not to be overrided by active line
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460)
   
    ### How should this be tested?
   
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Open a note and write some text.
   
    ### Screenshots (if appropriate)
   
    ![2460_active_line](https://cloud.githubusercontent.com/assets/4968473/26279598/de38b114-3df2-11e7-9d3a-f0d4f59b8cd1.gif)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2356
   
----
commit 6424db580c922fac03a42620340f2239d029babe
Author: 1ambda <[hidden email]>
Date:   2017-05-20T18:40:40Z

    feat: Highlight active line in editor

commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9
Author: 1ambda <[hidden email]>
Date:   2017-05-20T19:01:34Z

    fix: Control setting CSS not to overwrite active line

commit 0366948fe750478fc3c4ce946ba0e0383728fa21
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:51:03Z

    fix: Show single active line in a note

commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5
Author: 1ambda <[hidden email]>
Date:   2017-05-20T21:55:18Z

    fix: Use blue-light color for active line

commit bfa2fed75ab0d74ffec4d6b9b8eb69533e91dffe
Author: 1ambda <[hidden email]>
Date:   2017-05-21T13:59:43Z

    fix: Set active line when note is created

commit e60f9a2efc80a27d489f24650a71f47ffd1aee89
Author: 1ambda <[hidden email]>
Date:   2017-05-21T20:48:16Z

    feat: Display title, control in the same line

commit 087942b861ce02d15190e87c389e296db25e2a41
Author: 1ambda <[hidden email]>
Date:   2017-05-21T22:10:01Z

    fix: Use ng-if for title

commit 2809093dcce946d0978620c52d3b591e5514a906
Author: 1ambda <[hidden email]>
Date:   2017-05-21T23:14:25Z

    fix: xpath for select, checkbox DOM

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    @zjffdu Could you help review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    Awesome @1ambda I love this feature. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    Good! What about others?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    Merge to master if no further comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    This PR makes unnecessary margin above the Editor inside of Paragraph.
   
    before
    ![image](https://cloud.githubusercontent.com/assets/1540981/26764299/4640bb22-4919-11e7-8997-985178382583.png)
   
    after
    ![image](https://cloud.githubusercontent.com/assets/1540981/26764294/21c1b1f2-4919-11e7-9274-1f22826a3699.png)
   
    @1ambda Could you restore this margin to original?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    @Leemoonsoo Hi, Thanks for the feedback.
   
    - it is actually intended. otherwise highlight color will override the paragraph setting menus.
    - let me find an another way (e.g applying `z-index`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    Yeah, that was my guess. I think keeping layout unchanged is more important than prevent overlapping paragraph control and text editor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    @Leemoonsoo Are you working on this? or writing a commit to rollback layout only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    @Leemoonsoo I did some experiments to revert the original layout while keeping highlights. But I think it takes a time to fix. So here are few options.
   
    (A) revert 2356 and then reimplement the highlighting line feature considering original layout later.
    (B) keep current layout and refine designs so that new layout goes along with other components.
   
    And #2386 is for `(B)` while fixing some bugs. Could you consider `B` as well?
   
    ![](https://cloud.githubusercontent.com/assets/4968473/26712410/b868b7f0-47a1-11e7-9079-41f160ab7770.gif)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2356
 
    @1ambda Layout change impact user experiences a lot and i'd like to be more prudent on change.
   
    I have created PR for reverting it. https://github.com/apache/zeppelin/pull/2409


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---