[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
GitHub user cfries opened a pull request:

    https://github.com/apache/zeppelin/pull/2368

    Improved comment, removed admin user definition per default

    ### What is this PR for?
    Improved shiro.ini.template.
   
    Since the file is just a template, it should be such that if the user copies it from shiro.ini.template to shiro.ini the auth settings are comparable conservative.
    Hence: The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    In addition, the comment in the url section was misleading. It has been clarified. The comment "To enfore security, comment the line below and uncomment the next one“ was
    misleading, since the setting was already on "authc" and it was not the "line below". This has been fixed.
   
    ### What type of PR is it?
    [ Improvement]
   
    ### Todos
    * N/A
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2588
   
    ### How should this be tested?
    Non regression test / unit testing.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? *NO*
    * Is there breaking changes for older versions? *NO*
    * Does this needs documentation? *NO*
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfries/zeppelin improved-shiro-ini

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2368
   
----
commit e7606497fd34fa68c8d145ad5ef59955d40bbf46
Author: Christian Fries <[hidden email]>
Date:   2017-05-26T11:29:13Z

    Improved comment, removed admin user definition per default
   
    The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    The comment in the url section has been clarified. The comment "To
    enfore security, comment the line below and uncomment the next one“ was
    misleading. This has been fixed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...

zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2368
 
    Generally, it makes sense to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2368
 
    @cfries Hi, could you restart or fix the failed job?
   
    - https://travis-ci.org/cfries/zeppelin/builds/236343303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2368
 
    ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
In reply to this post by zjffdu
Github user cfries closed the pull request at:

    https://github.com/apache/zeppelin/pull/2368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
In reply to this post by zjffdu
GitHub user cfries reopened a pull request:

    https://github.com/apache/zeppelin/pull/2368

    Improved comment, removed admin user definition per default

    ### What is this PR for?
    Improved shiro.ini.template.
   
    Since the file is just a template, it should be such that if the user copies it from shiro.ini.template to shiro.ini the auth settings are comparable conservative.
    Hence: The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    In addition, the comment in the url section was misleading. It has been clarified. The comment "To enfore security, comment the line below and uncomment the next one“ was
    misleading, since the setting was already on "authc" and it was not the "line below". This has been fixed.
   
    ### What type of PR is it?
    [ Improvement]
   
    ### Todos
    * N/A
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2588
   
    ### How should this be tested?
    Non regression test / unit testing.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? *NO*
    * Is there breaking changes for older versions? *NO*
    * Does this needs documentation? *NO*
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfries/zeppelin improved-shiro-ini

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2368
   
----
commit e7606497fd34fa68c8d145ad5ef59955d40bbf46
Author: Christian Fries <[hidden email]>
Date:   2017-05-26T11:29:13Z

    Improved comment, removed admin user definition per default
   
    The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    The comment in the url section has been clarified. The comment "To
    enfore security, comment the line below and uncomment the next one“ was
    misleading. This has been fixed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
In reply to this post by zjffdu
Github user cfries closed the pull request at:

    https://github.com/apache/zeppelin/pull/2368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...

zjffdu
In reply to this post by zjffdu
Github user cfries commented on the issue:

    https://github.com/apache/zeppelin/pull/2368
 
    Re-open to give Jenkins a ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
In reply to this post by zjffdu
GitHub user cfries reopened a pull request:

    https://github.com/apache/zeppelin/pull/2368

    Improved comment, removed admin user definition per default

    ### What is this PR for?
    Improved shiro.ini.template.
   
    Since the file is just a template, it should be such that if the user copies it from shiro.ini.template to shiro.ini the auth settings are comparable conservative.
    Hence: The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    In addition, the comment in the url section was misleading. It has been clarified. The comment "To enfore security, comment the line below and uncomment the next one“ was
    misleading, since the setting was already on "authc" and it was not the "line below". This has been fixed.
   
    ### What type of PR is it?
    [ Improvement]
   
    ### Todos
    * N/A
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2588
   
    ### How should this be tested?
    Non regression test / unit testing.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? *NO*
    * Is there breaking changes for older versions? *NO*
    * Does this needs documentation? *NO*
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfries/zeppelin improved-shiro-ini

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2368
   
----
commit e7606497fd34fa68c8d145ad5ef59955d40bbf46
Author: Christian Fries <[hidden email]>
Date:   2017-05-26T11:29:13Z

    Improved comment, removed admin user definition per default
   
    The admin user has been commented out to avoid enabling admin by
    default with a default password.
   
    The comment in the url section has been clarified. The comment "To
    enfore security, comment the line below and uncomment the next one“ was
    misleading. This has been fixed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2368
 
    Thanks. Will merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2368: Improved comment, removed admin user definition...

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2368


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...