[GitHub] zeppelin pull request #2372: [ZEPPELIN-2581] Shell ansi codes

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
GitHub user DrIgor opened a pull request:

    https://github.com/apache/zeppelin/pull/2372

    [ZEPPELIN-2581] Shell ansi codes

    ### What is this PR for?
    Support ANSI escape codes for colors in shell interpreter output
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2581
   
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/2759002/26547220/90c162f2-4476-11e7-9fa4-4b023c1a415f.png)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin shell-ansi-codes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2372
   
----
commit 0804a3228c0aeec7e44d588168794d291bdbf25f
Author: Igor Drozdov <[hidden email]>
Date:   2017-05-26T10:58:53Z

    Support ANSI colors in shell outputs

commit 28f5ec53d863d731f7c0d7745bc40b7ea68facb2
Author: Igor Drozdov <[hidden email]>
Date:   2017-05-29T07:53:50Z

    Provide output in tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    Can we apply some theme to the output? For example,
   
    Solarized dark theme + shell syntax highlight.
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26560133/0d800262-44ef-11e7-879f-5f46e0317f57.png)
   
    AFAIK, we are using highlight.js
   
    https://github.com/apache/zeppelin/blob/master/zeppelin-web/bower.json#L27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    Cool!
    I'd love the dark theme, but I don't think we should force this onto users?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    I am not sure If themes should be shell interpreter feature. Maybe we can provide themes for every interpreter's text output?
   
    highlight.js should be used for input, not output. Output already contains information about colors and text styles


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    - the style is also a part of feature.
    - if we don't need styling output, then there is no reason to add css code for JDBC output. (table)
    - highlight.js is just a library. we can use anywhere we want to deliver the best.
    - if you don't want to include styling in this PR, it's ok. we can improve in the following PR. but Personally, I don't see this is good style.
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26579240/f58723c8-456d-11e7-8fa3-358f2a1e98bd.png)
   
    Here are few examples of what shell output should be. And that's the reason why many people customizing their shell.
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26579286/2685fed6-456e-11e7-8ee9-b5dcd46e836f.png)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26579329/44462842-456e-11e7-816d-e9c265b54e50.png)
   
   
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    I thought colorizing is included in this PR. But it's not part of this PR. Please forget about the last comment. I will create another JIRA ticket and work on that issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    I understand that `highlight.js` is a library and can be used anywhere. But we can't apply it to shell output because output is already highlighted. For example, `ls` inserts color codes to its output so we need to follow it.
   
    We can provide customization for colors (RGB code for blue, RGB for green and so on) and background color.
   
    Should I add this properties to shell interpreter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    @DrIgor FYI, see the custom initialization section
   
    - https://highlightjs.org/usage/
   
    Not sure colorizing should be handled in this PR. can be handled in JIRA 2604.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    Any other questions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2372: [ZEPPELIN-2581] Shell ansi codes

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2372
 
    I failed to test this feature since terminal i am using doesnt support that option. others can help review. sorry for the late reply.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---