[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add initial flow
    * [ ] - address for each storage class
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    TBD
   
    ### Screenshots (if appropriate)
    TBD
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit a8cccf6e6cf5b92d8d7e142bd4909b5a15e087a5
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial impl through env

commit fa6a60f40929b3682d3e790545e07220c3a1acbf
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T16:45:52Z

    add setting from UI initial

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add initial flow
    * [x] - address for each storage class
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    TBD
   
    ### Screenshots (if appropriate)
    TBD
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit 93ba59cf9d7122661f066ba0a0dd0b253dc584d8
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial impl through env

commit 6e7401beda06d3be86edfe7680bee9c77e0ed71c
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T16:45:52Z

    add setting from UI initial

commit 96421be5a64ea56529eaa499c18f1cc3cd92e378
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T06:47:29Z

    refactor settings into separate package

commit 7fb1adf423896c04e0b600f1fc52d9cbf4bef7f5
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T08:54:54Z

    check if permitted for all repos

commit d163e318c04e8e7736883d92231e16b3b98e3e26
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T12:42:41Z

    add note to checkpoint signature

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    this is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    Thanks for the contribution. Let me test and comment soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @khalidhuseynov I tested and works well in usual cases. However,
   
    1. Set `Persist on note commits`
    2. Execute paragraph
    3. Stop Zeppelin without committing.
   
    **In this case, The paragraph which was executed is not saved.**  But users normally expect all their changes will be saved. What do you think of?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @1ambda thanks for testing. yes that's the purpose of `save & commit`, the changes are applied in memory only unless it's explicitly saved and commit (persisted into file)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    Can we make *stopping zeppelin* also trigger *persist action*?
   
    - usually, people expect *stopping zeppelin* will save their changes regardless of whatever mode they are using. they might think *Zeppelin lost my changes!*
    - I guess, the original intention is that saving external storage everytime is a burden. But **stopping zeppelin** occurs only once. It's not a burden.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    yes that's true, i'll look into saving when stopping zeppelin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...