[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add initial flow
    * [ ] - address for each storage class
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    TBD
   
    ### Screenshots (if appropriate)
    TBD
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit a8cccf6e6cf5b92d8d7e142bd4909b5a15e087a5
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial impl through env

commit fa6a60f40929b3682d3e790545e07220c3a1acbf
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T16:45:52Z

    add setting from UI initial

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add initial flow
    * [x] - address for each storage class
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    TBD
   
    ### Screenshots (if appropriate)
    TBD
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit 93ba59cf9d7122661f066ba0a0dd0b253dc584d8
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial impl through env

commit 6e7401beda06d3be86edfe7680bee9c77e0ed71c
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T16:45:52Z

    add setting from UI initial

commit 96421be5a64ea56529eaa499c18f1cc3cd92e378
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T06:47:29Z

    refactor settings into separate package

commit 7fb1adf423896c04e0b600f1fc52d9cbf4bef7f5
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T08:54:54Z

    check if permitted for all repos

commit d163e318c04e8e7736883d92231e16b3b98e3e26
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-05T12:42:41Z

    add note to checkpoint signature

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    this is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    Thanks for the contribution. Let me test and comment soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @khalidhuseynov I tested and works well in usual cases. However,
   
    1. Set `Persist on note commits`
    2. Execute paragraph
    3. Stop Zeppelin without committing.
   
    **In this case, The paragraph which was executed is not saved.**  But users normally expect all their changes will be saved. What do you think of?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @1ambda thanks for testing. yes that's the purpose of `save & commit`, the changes are applied in memory only unless it's explicitly saved and commit (persisted into file)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    Can we make *stopping zeppelin* also trigger *persist action*?
   
    - usually, people expect *stopping zeppelin* will save their changes regardless of whatever mode they are using. they might think *Zeppelin lost my changes!*
    - I guess, the original intention is that saving external storage everytime is a burden. But **stopping zeppelin** occurs only once. It's not a burden.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    yes that's true, i'll look into saving when stopping zeppelin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add notebook repo setting
    * [x] - add save & commit
    * [x] - add tests
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    1. go to notebook repo menu and click on edit `Global settings`
    2. change value of `Note persistence` item to `Persist on note commits`
    3. go change any note, although it will be changed in memory, it won't be persisted
    4. to check above can reload notes in note list view -> will see original note
    5. can save note by `Save & Commit` in version control menu of note
   
    ### Screenshots (if appropriate)
    notebook repo menu
    <img width="1076" alt="screen shot 2017-06-12 at 5 57 12 pm" src="https://user-images.githubusercontent.com/1642088/27026300-41860ea4-4f98-11e7-8e5a-a36cb64b98fc.png">
   
   
    version control menu
    <img width="923" alt="screen shot 2017-06-12 at 5 55 04 pm" src="https://user-images.githubusercontent.com/1642088/27026217-fb43c152-4f97-11e7-86f1-627dea1fe3ce.png">
   
   
    ## Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit 2fb70ae2c365f5a02e8da182324db6847e4f5dfa
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial flow

commit 0a007f55d73e24ad9610861399b44c0a83dede09
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-09T07:14:07Z

    add temp test

commit 43d6cf6d18a4d4c5cdd58096e476a27f6a0d9e33
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-09T10:39:02Z

    rework settings into global

commit 7b7bedcdf8fd21bed4f617550c0197b49d7e3843
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T05:16:10Z

    change checkpoint signature with recent note

commit 4d93f482808719b8768c2ae5c1579d8921530ae0
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T05:16:55Z

    improve test

commit 5d7573dd6baa0e35bbb17eca569e8da7910ab713
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T06:42:01Z

    add large test for global setting change

commit e8aeb9660e869c5a0a791344086ea861ceb3c0d6
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T08:52:02Z

    add save & commit from note action bar

commit 0c035582964df6d85091635a39f208452e663edd
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T12:31:32Z

    fix test, set property back

commit 6ab4b597834b3e376f59e034f7ce1c967de3596c
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T13:34:01Z

    move setting from global to per repo and apply to remote s3 and zh

commit 5681d49055da94a527e39efc5faa910a53aa2b19
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-26T18:22:20Z

    add conditional save in s3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    What is the current persistent policy ? Does it persist on every run ?
   
    And the property name `zeppelin.notebook.persist.on.commit` is a little confusing to me.
    * If it is set to false, does it mean it would not persist when user click the saveAndCommit button ?
    * From the Database perspective (since commit is a concept from database), commit should mean persisting. If commit doesn't mean persisting, this might confuse users.
    * So I would suggest to use `zeppelin.notebook.persist.on.run` which mean doing persisting on each run.
    * BTW, we should also add doc to mention what is the purpose of this property. I guess it is for performance, but with the risk of losing data.
   
    What do you think ?
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @zjffdu the persistence policy is saving on run and almost on any note action. originally i introduced this feature globally on base class, however after some discussion above, introducing it for certain classes seems to be more reasonable since remote saves are costlier than local ones. regarding the questions:
     * when it's set to false there's only `Commit` button as before (make revision) instead of `Save & Commit` (save and make revision) as below
    ![save commit1](https://user-images.githubusercontent.com/1642088/27741887-8187b3ba-5df1-11e7-9598-1f7e0a01a1c8.gif)
    * yeah i agree that `commit` itself implies save. currently it's used in Zeppelin to denote creation of revision/checkpoint. So the idea was that in normal mode everything is saved automatically and you can `commit` current version whenever you want and with this feature enabled (only in S3 and ZHubRepo for now) you can `Save & Commit`.
    * persist on run is also another idea that could work, and would be nice to know opinion of more people on that. generally in that case save would be dependent on run, and `commit` would stay as before. @1ambda @Leemoonsoo what do you think about that?
    * i'll add documentation for it, regarding losing data since i changed local storage not to have this feature, it'll alway be saved locally and only for remote storages it could be mentioned in docs.
   
    let me know what you think on these points, thanks
   
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/2374

    [ZEPPELIN-2593] Add storage settings to persist on commit

    ### What is this PR for?
    adding settings to storage layer to let user choose to persist continuously or only on commits
   
   
    ### What type of PR is it?
    Improvement | Feature
   
    ### Todos
    * [x] - add notebook repo setting
    * [x] - add save & commit
    * [x] - add tests
   
    ### What is the Jira issue?
    [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)
   
    ### How should this be tested?
    1. go to notebook repo menu and click on edit `Global settings`
    2. change value of `Note persistence` item to `Persist on note commits`
    3. go change any note, although it will be changed in memory, it won't be persisted
    4. to check above can reload notes in note list view -> will see original note
    5. can save note by `Save & Commit` in version control menu of note
   
    ### Screenshots (if appropriate)
    notebook repo menu
    <img width="1076" alt="screen shot 2017-06-12 at 5 57 12 pm" src="https://user-images.githubusercontent.com/1642088/27026300-41860ea4-4f98-11e7-8e5a-a36cb64b98fc.png">
   
   
    version control menu
    <img width="923" alt="screen shot 2017-06-12 at 5 55 04 pm" src="https://user-images.githubusercontent.com/1642088/27026217-fb43c152-4f97-11e7-86f1-627dea1fe3ce.png">
   
   
    ## Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit 2fb70ae2c365f5a02e8da182324db6847e4f5dfa
Author: Khalid Huseynov <[hidden email]>
Date:   2017-05-29T07:48:06Z

    initial flow

commit 0a007f55d73e24ad9610861399b44c0a83dede09
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-09T07:14:07Z

    add temp test

commit 43d6cf6d18a4d4c5cdd58096e476a27f6a0d9e33
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-09T10:39:02Z

    rework settings into global

commit 7b7bedcdf8fd21bed4f617550c0197b49d7e3843
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T05:16:10Z

    change checkpoint signature with recent note

commit 4d93f482808719b8768c2ae5c1579d8921530ae0
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T05:16:55Z

    improve test

commit 5d7573dd6baa0e35bbb17eca569e8da7910ab713
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T06:42:01Z

    add large test for global setting change

commit e8aeb9660e869c5a0a791344086ea861ceb3c0d6
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T08:52:02Z

    add save & commit from note action bar

commit 0c035582964df6d85091635a39f208452e663edd
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T12:31:32Z

    fix test, set property back

commit 6ab4b597834b3e376f59e034f7ce1c967de3596c
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-12T13:34:01Z

    move setting from global to per repo and apply to remote s3 and zh

commit 5681d49055da94a527e39efc5faa910a53aa2b19
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-26T18:22:20Z

    add conditional save in s3

commit 64c15137978df3136699d8219b3ad40adf497d95
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-30T08:11:28Z

    fix spelling

commit 7ec21738d60104228d939fe08c7893d133790a20
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-30T09:29:04Z

    make option as non-actionable, don't broadcast

commit 50c88524fd8471dd34d2cb30f4d49df9e3b07a1a
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-30T10:47:10Z

    send note inside checkpoint payload

commit df78d4d154126225c4f5ce05ded9acbe5135073f
Author: Khalid Huseynov <[hidden email]>
Date:   2017-06-30T11:37:49Z

    fix test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    this is ready for more review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    > persist on run is also another idea that could work, and would be nice to know opinion of more people on that. generally in that case save would be dependent on run, and commit would stay as before. @1ambda @Leemoonsoo what do you think about that?
   
    One suggestion. Can we provide a dropdown for this option?
   
    - persist on running
    - persist on commit
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @1ambda good point, we can make both possible. i'll modify it to support both config then through dropdown


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2374
 
    @1ambda @zjffdu addressed the feedback and added persist on `run` as well. Also moved the logic out of storage classes. Please help further review and test this one to move on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12