[GitHub] zeppelin pull request #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2375

    [ZEPPELIN-2527] Use thin (normal) cursor.

    ### What is this PR for?
   
    Previously, it's hard to recognize where (**before or after**) the cursor is since it's too thick.
   
    See the attached GIFs for comparison.
   
    These key bindings are still supported in the default mode.
   
    - `CTRL + P`, `CTRL+N`: go to next / previous line
    - `CTRL + F`, `CTRL+B`: go to next / previous letter
    - `CTRL + A`, `CTRL+E`: go to the beginning / end of the line
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Use default mode instead of emacs
    * [x] - Bind `CTRL + P` for OSX.
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2527](https://issues.apache.org/jira/browse/ZEPPELIN-2527)
   
    ### How should this be tested?
   
    1. Build: `mvn clean package -DskipTests;`
    2. Open a paragraph.
    2. Check the cursor
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26563706/0b2c9846-4511-11e7-9667-da4c28321429.png)
   
    ![2527_before](https://cloud.githubusercontent.com/assets/4968473/26563687/b7133c88-4510-11e7-9acc-0baea08f29fc.gif)
   
    #### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26563705/ff5809ce-4510-11e7-8697-831e90e9d5a2.png)
   
    ![2527_after](https://cloud.githubusercontent.com/assets/4968473/26563690/c1bcd982-4510-11e7-9032-eb5c4a28e976.gif)
   
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2527/cursor-in-editor-is-too-thick

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2375
   
----
commit 069714580f7777cac676fba937a81fff5f96a4e9
Author: 1ambda <[hidden email]>
Date:   2017-05-29T23:09:28Z

    fix: Use default mode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2375
 
    @zjffdu Could you help review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
In reply to this post by herval
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2375
 
    Thanks @1ambda LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
In reply to this post by herval
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2375
 
    Do we need to keep undocumented emacs shortcuts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
In reply to this post by herval
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2375


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

herval
In reply to this post by herval
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2375
 
    Let me find a different way. Changing cursor while keeping emacs shortcut.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...