[GitHub] zeppelin pull request #2379: [MINOR] fix: Remove newlines in spark tutorial ...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2379: [MINOR] fix: Remove newlines in spark tutorial ...

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2379

    [MINOR] fix: Remove newlines in spark tutorial output

    ### What is this PR for?
   
    fix: Remove newlines in spark tutorial output.
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
   
    DONE
   
    ### What is the Jira issue?
   
    MINOR
   
    ### How should this be tested?
   
    1. Checkout PR.
    2. Open the `Zeppelin Tutorial / Basic Features(Spark)` notebook
    3. Check the output.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26576428/ddd50236-4563-11e7-9cb4-ecfd2c888421.png)
   
    #### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26576451/ea0601c2-4563-11e7-9efa-f4f0d581000b.png)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin MINOR/update-spark-tutorial-paragraph

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2379
   
----
commit 09c98b7e6aa4f674b133e78f7bbc14c63f47109f
Author: 1ambda <[hidden email]>
Date:   2017-05-30T09:12:49Z

    fix: Remove newlines in spark tutorial output

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2379: [MINOR] fix: Remove newlines in spark tutorial ...

zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2379


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2379: [MINOR] fix: Remove newlines in spark tutorial ...

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2379

    [MINOR] fix: Remove newlines in spark tutorial output

    ### What is this PR for?
   
    fix: Remove newlines in spark tutorial output. I attached screenshots.
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
   
    DONE
   
    ### What is the Jira issue?
   
    MINOR
   
    ### How should this be tested?
   
    1. Check out this PR.
    2. Build
    3. Open the `Zeppelin Tutorial / Basic Features(Spark)` notebook
    4. Check the output.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26576428/ddd50236-4563-11e7-9cb4-ecfd2c888421.png)
   
    #### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26576451/ea0601c2-4563-11e7-9efa-f4f0d581000b.png)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin MINOR/update-spark-tutorial-paragraph

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2379
   
----
commit 09c98b7e6aa4f674b133e78f7bbc14c63f47109f
Author: 1ambda <[hidden email]>
Date:   2017-05-30T09:12:49Z

    fix: Remove newlines in spark tutorial output

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2379: [MINOR] fix: Remove newlines in spark tutorial output

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2379
 
    @Leemoonsoo @felixcheung Thanks for the review.
   
    - I removed all the things which are not related to the output.
    - and the paragraph in the spark tutorial now looks
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26704535/abf9822e-476a-11e7-9536-db2fb63630bc.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2379: [MINOR] fix: Remove newlines in spark tutorial output

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2379
 
    Hi all. ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2379: [MINOR] fix: Remove newlines in spark tutorial ...

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2379


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...