[GitHub] zeppelin pull request #2381: [WIP] [ZEPPELIN-2583] Updating offcial main web...

classic Classic list List threaded Threaded
28 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2381: [WIP] [ZEPPELIN-2583] Updating offcial main web...

zjffdu
GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2381

    [WIP] [ZEPPELIN-2583] Updating offcial main website

    ## What is this PR for?
    This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage.
   
    To sum up, `Technologies` section is consist of  3 interpreters most people search or want (already talking about this on the mailing list.) and, `Deployments` section describes single or multiple user setting.
   
    Please check **TODO** list and Screenshots for detail. Plus, note that this PR is related #2371 PR.
   
    ## What type of PR is it?
    [Improvement ]
   
    ## Todos
    * [x] - change navigation bar items.
           - add `Quick Start`
           - move `Community` and add `Github` in here
    * [x] - remove 'Apache Aeppelin' title in the blue section and change button.
           - `Get Started` and `Download`
    * [x] - add form and mouse event css for quick interpreter links section (Technologies).
    * [x] - add form and css for user setting option (Deployments).
    * [ ] - connect to each quick links. (@1ambda, could you review about this, please?)
    * [ ] - adding zeppelin log image in the blue section.
   
    ## What is the Jira issue?
    * [ZEPPELIN-2583](https://issues.apache.org/jira/browse/ZEPPELIN-2583)
   
    ## How should this be tested?
    1. run `bundle exec jekyll serve --watch` in this branch
    2. open `localhost:4000`
   
    ## Screenshots (if appropriate)
    ### 1. overall shape
    ![image](https://cloud.githubusercontent.com/assets/8110458/26599764/b6ca8980-45b4-11e7-8584-b4ba1e5f314f.png)
   
    ### 2. changed navigation
    ![changed_navigation](https://cloud.githubusercontent.com/assets/8110458/26599826/f25c169e-45b4-11e7-91a7-607a03bb2333.gif)
   
    ### 3. Technologies
    ![technologies](https://cloud.githubusercontent.com/assets/8110458/26599891/22be98fc-45b5-11e7-838e-21ce2c3a7b37.gif)
   
   
    ### 4. Deployments
    ![deployments](https://cloud.githubusercontent.com/assets/8110458/26599998/66bc576a-45b5-11e7-8950-db0f970c8e52.gif)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, this is


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin updating-offcial-Main-Website

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2381
   
----
commit 4a4f24527f8abd4c45f979ea10525449fd56b277
Author: soralee <[hidden email]>
Date:   2017-05-29T11:01:24Z

    initial updating to main homepage

commit 998c745f2748007d074c0e7102254eb0aef6e7fe
Author: soralee <[hidden email]>
Date:   2017-05-30T18:13:14Z

    change button and quick interpreter and user setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    @soralee Thanks for updating official page. Could you add `[gh-pages]` prefix to the PR title?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    regarding navbar-collapse button, it would be nice to modify `navbar-inverse. .navbar-toggle` classes style in style.css:L151 to
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26614909/3643485c-45fe-11e7-9d8b-fda7e5b35974.png)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26614913/3be33ede-45fe-11e7-9af1-84e67024dc8c.png)
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Setting border color to white would be better.
    For code, you can refer https://github.com/apache/zeppelin/pull/2355
   
    ### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26614977/ba44a1be-45fe-11e7-82cc-5ec6a74401c3.png)
     
    ### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26614985/c6597b96-45fe-11e7-9e14-6c485bdd2bd6.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Background colors and text styles can be improved.
   
    ### Current
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615080/566549e0-45ff-11e7-829f-42b69c2c6240.png)
   
    ### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615066/43f70190-45ff-11e7-8646-b57adcd67b6c.png)
   
    ### Code
   
    For title, let's use `text-shadow: 1px 2px #353131` for better readability.
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Layout in small browser can be improved too.
   
    ### Current
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615101/7c0faeec-45ff-11e7-8f03-df01f06e37b6.png)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615106/814abb4a-45ff-11e7-9e9c-33f5de059313.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Can we improve the layout this section too? Currently, it looks like
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615166/ea1de930-45ff-11e7-871d-b7b049cd78b0.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Descriptions in the **TECHNOLOGIES** section is too small. It's hard to read.
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615192/0ec2236e-4600-11e7-97cd-92f79176bfe1.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    If it's impossible to specific logos (e.g mysql, postres) due to license in the **SQL** button, IMO we can apply this kind of design. (font is not fancy, but we can improve.)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615246/7a692afe-4600-11e7-8c86-6d50465b9ad3.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Also, icons and texts are slightly moved in a medium size browser.
   
    ### NORMAL: Large Size Browser
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615306/c793b4d4-4600-11e7-82ab-b0475c12de2c.png)
   
    ### PROBLEM: Medium Size Browser
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615302/c2849a3a-4600-11e7-9595-4db55463717a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Can we use a different color for hovered button?
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615360/33f46592-4601-11e7-977c-a0da499b4382.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [ZEPPELIN-2597] Updating offcial main website

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Buttons in navbar are not fully hovered. Height should be 60.
    You can refer https://github.com/apache/zeppelin/pull/2355
   
    ### Current
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615496/3262c376-4602-11e7-9d02-0c4e151e8b51.png)
   
    ### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26615510/55cf91c2-4602-11e7-8cc9-853beb41027a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Wow, @1ambda, thanks a lots for review!
    I'll improve as your comments!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    How about
   
    "For single user" -> "Single user"
    "For multi user" -> "Multi user"
   
    ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Hi, all.
    There are many feedback in here so, I've arranged the following TODO list for sharing progress.  
   
    1) in blue section
    - [x] add zeppelin logo in the blue section
    - [x] fix to bug about misalign apache zeppelin text and icon
    - [ ] change `Get started` button hover color
    - [ ] connecting a link to `Get started` button
   
    2) regarding to improve navbar
     - [ ] apply style
     - [ ] change border color
     - [ ] change background color and text style
     - [ ] fix not fully hovered color
   
   
    3) regarding to improve layout
     - [x] when resizing window
     - [x] change multi-user icon
     - [ ] improve what's new section
   
   
    4) in technologies section
    - [x] set more bigger text in technologies
    - [ ] apply sql font
    - [ ] connecting quick start links
   
   
    5)  in deployments section
    - [x] change title for user setting option (single user, multi user)
    - [ ] connecting quick start links


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    I'm improving navigation bar but, I found two bug in navigation bar.
    so we should resolve those issues together.
    1. when resizing window, drop-toggle is appeared.
    ![bug1](https://cloud.githubusercontent.com/assets/8110458/26674878/d5807f9e-46fc-11e7-936d-d07f413fecd0.gif)
   
    2. after using navigation bar in small window, and then drop-toggle place is misaligned in big window.
    ![bug2](https://cloud.githubusercontent.com/assets/8110458/26675376/a20547ba-46fe-11e7-94a5-a9206fd8aa2a.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    one more bug problem, if I escape `download` menu, color still leaves active color.
    ![hover bug](https://cloud.githubusercontent.com/assets/8110458/26714144/26e9d3ea-47ab-11e7-9496-d1072b1aca25.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Hi, finally I finished the above To-do list.
    @1ambda @Leemoonsoo Could you confirm this, again?
   
    For now, the quick links is connected with 0.8.0-SNAPSHOT documentation. @Leemoonsoo could you advice this, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

zjffdu
In reply to this post by zjffdu
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    Thank you for great work! Especially big +1 for adding this section
   
    <img width="1219" alt="screen shot 2017-06-04 at 11 27 48 am" src="https://cloud.githubusercontent.com/assets/10060731/26764287/e5b90aa2-4918-11e7-908c-1fdfd4870037.png">
   
    I've always thought we need this kind of guide in first page of website.
   
    I quickly look through the change and here are some thought in my head.
   
    ### 1. Navbar
     - before
    <img width="1144" alt="screen shot 2017-06-04 at 11 20 39 am" src="https://cloud.githubusercontent.com/assets/10060731/26764234/1be270e2-4918-11e7-976c-ed07289479b2.png">
   
     - after
    <img width="1185" alt="screen shot 2017-06-04 at 11 20 22 am" src="https://cloud.githubusercontent.com/assets/10060731/26764235/1ec0bd82-4918-11e7-981c-4ba4f3c119b8.png">
   
    Adding "Quick Start" menu and switching menu order are really good idea I think. But not sure about making the font size bigger and adding too much shadow. So in my opinion, just below work will be enough.
   
        - Adding "Quick Start" menu
        - Switching menu order
   
   
    ### 2. Main
    I also agree this part doesn't have really good looking.
    <img width="1217" alt="screen shot 2017-06-04 at 11 37 38 am" src="https://cloud.githubusercontent.com/assets/10060731/26764349/4a00b96e-491a-11e7-9f06-6841bff11b50.png">
   
    But not sure the new change is definitely better than current one.
    <img width="1174" alt="screen shot 2017-06-04 at 11 38 22 am" src="https://cloud.githubusercontent.com/assets/10060731/26764350/55ed2a46-491a-11e7-8f14-12cd3ff2385b.png">
   
   
   
    I think it'll be better to update other parts expect "Technologies" & "Deployments" that you newly added in another PR step by step. That would be easier to get review/ consensus from other ppl and also easier to make it merged. I mean we can separate the work like below.
   
    ```
    1. update navbar
    2. update main section
    3. adding "Technologies" & "Deployment" section
    4. minor styling
    ....
    ```
    What do you think?
    Thanks again for staring this work.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...

zjffdu
In reply to this post by zjffdu
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2381
 
    @AhyoungRyu Thanks for your opinions!
    But, Sorry for sending disagreement message.
     
    First, `Navbar` part is that the basis is #2371 PR. We should match this new feature and, I think font and shadow of `navbar` is better than before.
   
    And `Main` part is that `Apache Zeppelin` takes currently the position too much and, many `Apache Zeppelin` is placed in main page.
    Also, a user already know this page is `Apache Zeppelin` page so, we don't need to put `Apache Zeppelin` big font. furthermore, I think it is more important to inform the sentence which  is placed in under `Apache Zeppelin` to users.  
   
    Therefore, this PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage. So I don't agree that PR is separated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12