[GitHub] zeppelin pull request #2382: [ZEPPELIN-2185] No tooltip displayed on chart t...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2382: [ZEPPELIN-2185] No tooltip displayed on chart t...

zjffdu
GitHub user 0qtttt opened a pull request:

    https://github.com/apache/zeppelin/pull/2382

    [ZEPPELIN-2185] No tooltip displayed on chart type button

    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
   
   
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
   
    ### How should this be tested?
    Outline the steps to test the PR here.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/0qtttt/zeppelin branch-0.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2382
   
----
commit c4e54cac6c3727aa348eeff93a29de9d6edecc29
Author: ygpark <[hidden email]>
Date:   2017-05-30T09:05:18Z

    [ZEPPELIN-2185] No tooltip displayed on chart type button

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2382: [ZEPPELIN-2185] No tooltip displayed on chart type but...

zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2382
 
    Thanks for the contribution @0qtttt.
   
    1. To pass CI, you need to setup travis CI for your zeppelin fork. The forked repository name must be `zeppelin`.
   
    - https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   
    2. It would be nicer to add screenshots for **before**, **after**.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2382: [ZEPPELIN-2185] No tooltip displayed on chart type but...

zjffdu
In reply to this post by zjffdu
Github user 0qtttt commented on the issue:

    https://github.com/apache/zeppelin/pull/2382
 
    Thank you, I'm sorry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2382: [ZEPPELIN-2185] No tooltip displayed on chart type but...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2382
 
    @0qtttt Hi! Any update? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2382: [ZEPPELIN-2185] No tooltip displayed on chart t...

zjffdu
In reply to this post by zjffdu
Github user 0qtttt closed the pull request at:

    https://github.com/apache/zeppelin/pull/2382


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...