[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

zjffdu
GitHub user andreaTP opened a pull request:

    https://github.com/apache/zeppelin/pull/2383

    [ZEPPELIN-2606] Fix compilation with R interpreter enabled

    ### What is this PR for?
    `mvn -DskipTests clean package -Pr` fails
   
    ### What type of PR is it?
    Bug Fix
   
    ### What is the Jira issue?
     [ZEPPELIN-2606]
   
    ### How should this be tested?
    `mvn -DskipTests clean package -Pr`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nokia/zeppelin rInterpreterFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2383
   
----
commit b237615c83eddc4107d039c6d276a2cf5a089b00
Author: andrea <[hidden email]>
Date:   2017-05-31T15:36:28Z

     [ZEPPELIN-2606] Fix compilation with R interpreter enabled

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user andreaTP commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    yes a full compilation with all interpreters available should be included in CI build IMO ....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    I think `r` is missing in `INTERPRETERS` of `.travis.yml`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user andreaTP commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    `INTERPRETERS` is surprisingly an exclusion list @zjffdu https://github.com/apache/zeppelin/blob/master/.travis.yml#L40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    @andreaTP That's is intended. It would be converted to inclusive.
   
    ```
    MODULES="-pl $(echo .,zeppelin-interpreter,${INTERPRETERS} | sed 's/!//g')"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user andreaTP commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    good point, so I added it to the list, I think it fits the scope of this PR (let see what travis says)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

zjffdu
In reply to this post by zjffdu
Github user andreaTP closed the pull request at:

    https://github.com/apache/zeppelin/pull/2383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user andreaTP commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    Since R is under spark we need to enable it differently AFAICS
    now it is enabled at least in one test (where all other interpreters are compiled).
    Travis is happy I close and re-open this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

zjffdu
In reply to this post by zjffdu
GitHub user andreaTP reopened a pull request:

    https://github.com/apache/zeppelin/pull/2383

    [ZEPPELIN-2606] Fix compilation with R interpreter enabled

    ### What is this PR for?
    `mvn -DskipTests clean package -Pr` fails
   
    ### What type of PR is it?
    Bug Fix
   
    ### What is the Jira issue?
     [ZEPPELIN-2606]
   
    ### How should this be tested?
    `mvn -DskipTests clean package -Pr`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nokia/zeppelin rInterpreterFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2383
   
----
commit b237615c83eddc4107d039c6d276a2cf5a089b00
Author: andrea <[hidden email]>
Date:   2017-05-31T15:36:28Z

     [ZEPPELIN-2606] Fix compilation with R interpreter enabled

commit 6ef05953e07e962acab9087133b222435efa1ef1
Author: andrea <[hidden email]>
Date:   2017-06-01T11:41:50Z

    included R interpreter in travis

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    I have general question. Does -Pr works at the latest spark distribution?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user necosta commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    Q: Does -Pr works at the latest spark distribution?
    A: Not sure. It works with 2.0.2. I haven't tried to compile it against 2.1.1. Any specific error you are getting?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    Thanks, I just wonder if it works becase it was developed when spark was 1.5. One more question. Did you test -sparkR ? If you did, can you compare which one is proper for you? We had two different implementations and it's a bit hard to maintain it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user necosta commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    I'm no expert so don't trust my answer. I have both enabled and working, %r and %spark.r. The way I understand it, %r is just an interpreter to allow coding in R (as you would do in RStudio). And %spark.r is R + Spark, so you are able to interface with Spark in R as you would in Python or Scala. Which one to use?
     depends on your use case I guess.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user andreaTP commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    do this need anything else to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2383
 
    will be merging into master if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---