[GitHub] zeppelin pull request #2384: [ZEPPELIN-2577] No graphs visible on IE11

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/2384

    [ZEPPELIN-2577] No graphs visible on IE11

    ### What is this PR for?
    This PR fixes issue described in https://issues.apache.org/jira/browse/ZEPPELIN-2577 by adding .endsWith method.
   
   
    ### What type of PR is it?
    Bug Fix
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2577
   
    ### How should this be tested?
    Build this PR and make sure built-in visualization is displayed in ie11
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2384
   
----
commit 1b3129c015e9b3950bfdb6abf98de795c4379224
Author: Lee moon soo <[hidden email]>
Date:   2017-06-01T20:19:31Z

    polyfill .endswith

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    Thanks @1ambda @prabhjyotsingh for the review. Merge to master and branch-0.7 if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    @Leemoonsoo I think we don't need to merge this PR into master. because the master branch supports IE9+
   
    ```
     "browsers": ["last 5 version", "> 5%", "edge >= 12", "ie >= 9", "safari 7", "chrome 47", "firefox 31"]
    ```
   
    - https://github.com/apache/zeppelin/blob/master/zeppelin-web/.babelrc#L8



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    Tested the Master branch in IE11. and got different error.
   
    ![image](https://cloud.githubusercontent.com/assets/1540981/26710534/607ee4ca-470f-11e7-8adb-59c0d0954ac6.png)
   
    @1ambda Do you know reason why master branch and branch-0.7 has different .babelrc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    https://github.com/apache/zeppelin/pull/2273 was merged into master only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    Regarding to Promsie polyfill, we need to turn on the `useBuiltIn` option in babel-preset-env
   
    - https://github.com/babel/babel-preset-env#usebuiltins
    - https://github.com/babel/babel-preset-env/issues/203



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    I tried `useBuiltIn` in master branch. but it didn't help. Anyway, that can be handled in another issue.
   
    I'll merge this PR to branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    After merging this PR, let's proceed to release 0.7.2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user Leemoonsoo closed the pull request at:

    https://github.com/apache/zeppelin/pull/2384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2384
 
    Merged to IE11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---