[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2385

    [ZEPPELIN-2609] Add missing shortcut descriptions

    ### What is this PR for?
   
    Add missing shortcut descriptions. Refer the *TODOs* section and attached screenshots for detail.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Move `CTRL-N`, `CTRL-P` to the editor shortcut section.
    * [x] - Remove useless bottom border color.
    * [x] - Add missing shortcut desc `CTRL-F` and `CTRL-B`
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2609](https://issues.apache.org/jira/browse/ZEPPELIN-2609)
   
    ### How should this be tested?
   
    1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. open any notebook
    3. click the keyboard shortcut dialog.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26706040/2dd05c96-4775-11e7-8c85-39b6a5e7d2a7.png)
   
    #### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26706030/230c7bbe-4775-11e7-83f5-3f2f8e86604a.png)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2609/add-missing-shortcut-desc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2385
   
----
commit 58930fb8ca021923d6f301809a49589490fb37d4
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:16:37Z

    fix: Move CTRL-N,P to editor shortcut section

commit 6e6ca8f0be26a0de9e1a334eeb6249951706e744
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:16:48Z

    style: reindent

commit 9b8222e679c5d46998b6f6bd05eed4c5cdd9de12
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:17:46Z

    fix: Remove useless bottom sep

commit 0e2d201d289a7010eb4e0e3163981a85531524da
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:20:12Z

    feat: Add missing shortcut desc CTRL-F,B

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2385: [ZEPPELIN-2609] Add missing shortcut descriptions

zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2385
 
    @soralee Could you help review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2385

    [ZEPPELIN-2609] Add missing shortcut descriptions

    ### What is this PR for?
   
    Add missing shortcut descriptions. Refer the *TODOs* section and attached screenshots for detail.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [x] - Move `CTRL-N`, `CTRL-P` to the editor shortcut section.
    * [x] - Remove useless bottom border color.
    * [x] - Add missing shortcut desc `CTRL-F` and `CTRL-B`
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2609](https://issues.apache.org/jira/browse/ZEPPELIN-2609)
   
    ### How should this be tested?
   
    1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. open any notebook
    3. click the keyboard shortcut dialog.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26706040/2dd05c96-4775-11e7-8c85-39b6a5e7d2a7.png)
   
    #### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26706030/230c7bbe-4775-11e7-83f5-3f2f8e86604a.png)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2609/add-missing-shortcut-desc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2385
   
----
commit 58930fb8ca021923d6f301809a49589490fb37d4
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:16:37Z

    fix: Move CTRL-N,P to editor shortcut section

commit 6e6ca8f0be26a0de9e1a334eeb6249951706e744
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:16:48Z

    style: reindent

commit 9b8222e679c5d46998b6f6bd05eed4c5cdd9de12
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:17:46Z

    fix: Remove useless bottom sep

commit 0e2d201d289a7010eb4e0e3163981a85531524da
Author: 1ambda <[hidden email]>
Date:   2017-06-02T00:20:12Z

    feat: Add missing shortcut desc CTRL-F,B

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2385


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2385: [ZEPPELIN-2609] Add missing shortcut descriptions

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2385
 
    ping @soralee


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2385


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2385: [ZEPPELIN-2609] Add missing shortcut descriptions

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2385
 
    @soralee Sorry for confusing. Just forget about the mention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...