[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2386

    [ZEPPELIN-2603] fix: Broken Paragraph Title

    ### What is this PR for?
   
    Paragraph titles are split into multiple lines when they are long.
   
    - let's applying text-overflow like the note title.
    - while making paragraph titles have fixed height for seamless title hiding/showing
   
    ### What type of PR is it?
    [Bug Fix | Improvement]
   
    ### Todos
    * [x] - text-overflow for paragraph titles
    * [x] - fixed height for paragraph titles.
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2603](https://issues.apache.org/jira/browse/ZEPPELIN-2603)
   
    ### How should this be tested?
   
    1. build
    2. open any note
    3. show / hide a paragraph title
    4. insert long a paragraph title.
   
    ### Screenshots (if appropriate)
   
    #### Before: paragraph title is split into multiple lines
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712431/cf229196-47a1-11e7-9b6e-473f1006c743.png)
   
    #### Before: enabling paragraph title has an effect on the height of a paragraph.
   
    ![2603_before](https://cloud.githubusercontent.com/assets/4968473/26712476/fd3b618e-47a1-11e7-8a00-3720d46c9ecc.gif)
   
    #### After: enabling / disalbing a paragraph title seamlessly
   
    ![2603_after](https://cloud.githubusercontent.com/assets/4968473/26712410/b868b7f0-47a1-11e7-9079-41f160ab7770.gif)
   
    #### After: text-overflow for a paragraph title
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712357/7bd02616-47a1-11e7-9912-0463fd3a7565.png)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712364/82b1f342-47a1-11e7-8431-37a990050a82.png)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2603/fix-broken-paragraph-title

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2386
   
----
commit 1608f8b0839e602136cbb32eb9efd8a29c86abdc
Author: 1ambda <[hidden email]>
Date:   2017-06-02T04:14:32Z

    fix: use more meaningful css class names

commit 01014ba9aeb3145e6bc47496bcaf1114018ba1a5
Author: 1ambda <[hidden email]>
Date:   2017-06-02T04:35:17Z

    style: reindent title related DOM

commit dd5d37d23e1d8932b36456723ed56b2b50c5e64d
Author: 1ambda <[hidden email]>
Date:   2017-06-02T05:06:19Z

    fix: seamless title display with text-overflow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2386

    [ZEPPELIN-2603] fix: Broken Paragraph Title

    ### What is this PR for?
   
    Paragraph titles are split into multiple lines when they are long.
   
    - let's applying text-overflow like the note title.
    - while making paragraph titles have fixed height for seamless title hiding/showing
   
    ### What type of PR is it?
    [Bug Fix | Improvement]
   
    ### Todos
    * [x] - text-overflow for paragraph titles
    * [x] - fixed height for paragraph titles.
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2603](https://issues.apache.org/jira/browse/ZEPPELIN-2603)
   
    ### How should this be tested?
   
    1. build
    2. open any note
    3. show / hide a paragraph title
    4. insert long a paragraph title.
   
    ### Screenshots (if appropriate)
   
    #### Before: paragraph title is split into multiple lines
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712431/cf229196-47a1-11e7-9b6e-473f1006c743.png)
   
    #### Before: enabling paragraph title has an effect on the height of a paragraph.
   
    ![2603_before](https://cloud.githubusercontent.com/assets/4968473/26712476/fd3b618e-47a1-11e7-8a00-3720d46c9ecc.gif)
   
    #### After: enabling / disalbing a paragraph title seamlessly
   
    ![2603_after](https://cloud.githubusercontent.com/assets/4968473/26712410/b868b7f0-47a1-11e7-9079-41f160ab7770.gif)
   
    #### After: text-overflow for a paragraph title
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712357/7bd02616-47a1-11e7-9912-0463fd3a7565.png)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26712364/82b1f342-47a1-11e7-8431-37a990050a82.png)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2603/fix-broken-paragraph-title

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2386
   
----
commit 1608f8b0839e602136cbb32eb9efd8a29c86abdc
Author: 1ambda <[hidden email]>
Date:   2017-06-02T04:14:32Z

    fix: use more meaningful css class names

commit 01014ba9aeb3145e6bc47496bcaf1114018ba1a5
Author: 1ambda <[hidden email]>
Date:   2017-06-02T04:35:17Z

    style: reindent title related DOM

commit dd5d37d23e1d8932b36456723ed56b2b50c5e64d
Author: 1ambda <[hidden email]>
Date:   2017-06-02T05:06:19Z

    fix: seamless title display with text-overflow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2386
 
    Will be modified after resolving the last comment of https://github.com/apache/zeppelin/pull/2356


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---