[GitHub] zeppelin pull request #2387: [ZEPPELIN-2573] fix: Small font-size for navbar...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2387: [ZEPPELIN-2573] fix: Small font-size for navbar...

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2387

    [ZEPPELIN-2573] fix: Small font-size for navbar menus

    ### What is this PR for?
   
    Navbar style was changed by https://github.com/apache/zeppelin/pull/2355
    But font-size for navbar menu is too small.
   
    See the screenshots.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
   
    DONE
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2573](https://issues.apache.org/jira/browse/ZEPPELIN-2573)
   
    ### How should this be tested?
   
    1. Build
    2. Open `localhost:8080`
   
    ### Screenshots (if appropriate)
   
    #### Before: Small font-size for navbar menus (16px)
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26713165/207cd930-47a6-11e7-88bd-8e4f4e5ccfdc.png)
   
    #### After:  font-size: 18px
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26713155/1337dc8e-47a6-11e7-887b-2bde5ddce8c3.png)
   
   
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2573/cont-improve-navbar-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2387
   
----
commit aa7a1fc8d16d6a7fe00396c41f0915a7f3464a1b
Author: 1ambda <[hidden email]>
Date:   2017-06-02T06:11:23Z

    fix: Increase font-size for navbar menus

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2387: [ZEPPELIN-2573] fix: Small font-size for navbar...

zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2387


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---