[GitHub] zeppelin pull request #2388: [ZEPPELIN-2492] Use single Dockerfile for each ...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2388: [ZEPPELIN-2492] Use single Dockerfile for each ...

prabhjyotsingh
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2388

    [ZEPPELIN-2492] Use single Dockerfile for each tag (branch-0.7)

    ### What is this PR for?
   
    **This PR is created for branch-0.7. for master, https://github.com/apache/zeppelin/pull/2318 was already merged**
   
    Use single `Dockerfile` for each release since [apache infra uses tag pushes](https://issues.apache.org/jira/browse/INFRA-12781) to build an image.
   
    - https://issues.apache.org/jira/browse/INFRA-12781
   
    After release process finishes, dockerhub will build using the pushed tag.
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2492](https://issues.apache.org/jira/browse/ZEPPELIN-2492)
   
    ### How should this be tested?
   
    1. `./dev/change_zeppelin_version.sh 0.8.0-SNAPSHOT 0.7.1`
    2. Check that version is properly set: `vi scrtips/docker/zeppelin/bin/Dockerfile`
    3. Build docker image `cd scripts/docker/zeppelin/bin; docker build -t zeppelin:0.7.1 ./`
    4. Run the image: `docker run -p 8080:8080  --rm --name zeppelin zeppelin:0.7.1`
   
    ### Screenshots (if appropriate)
   
    NONE
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2492/use-single-dockerfile-for-each-tag-branch07

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2388
   
----
commit 14710963edb5e30426bcf4742e8a6d088723924d
Author: 1ambda <[hidden email]>
Date:   2017-06-02T06:21:43Z

    feat: Add dockerfile for tag push

commit 64b3fe06d7d567808ea9327132b8efe8f5f8f7a3
Author: 1ambda <[hidden email]>
Date:   2017-06-02T06:24:38Z

    docs: Update docker.md

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2388: [ZEPPELIN-2492] Use single Dockerfile for each tag (br...

prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2388
 
    @Leemoonsoo This is created for branch-0.7. For master, https://github.com/apache/zeppelin/pull/2318 was already merged.
   
    Could you help to review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2388: [ZEPPELIN-2492] Use single Dockerfile for each tag (br...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2388
 
    I'll merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2388: [ZEPPELIN-2492] Use single Dockerfile for each tag (br...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2388
 
    Can you close it by yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2388: [ZEPPELIN-2492] Use single Dockerfile for each tag (br...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2388
 
    Thanks @jongyoul.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2388: [ZEPPELIN-2492] Use single Dockerfile for each ...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2388


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---