[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2391

    [ZEPPELIN-2501] Better Job Navigation Experience

    ### What is this PR for?
   
    Improve UX for Job Navigation. Please refer the *TODOs* section and screenshots attached below for detail.
   
    FYI, **pagination** is added to improve page loading speed. Currently, it is going to be slow when there are 50+ jobs.
   
    ### What type of PR is it?
    [Improvement | Feature]
   
    ### Todos
    * [x] - improve UI
    * [x] - add pagination to improve page loading speed
    * [x] - interactive job searching without *enter key*
    * [x] - add date sorter
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2501](https://issues.apache.org/jira/browse/ZEPPELIN-2501)
   
    ### How should this be tested?
   
    1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. open the job page: `http://localhost:8080/#/jobmanager`
    3. try to search, filter, sort.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729918/39f51c8a-47ea-11e7-88a1-30ffa5947e3a.png)
   
    #### After: Larger UI components
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729934/48ea4c74-47ea-11e7-91f0-4aa97bb93161.png)
   
    #### After: Interactive search without enter-key
   
    ![2501_interactive](https://cloud.githubusercontent.com/assets/4968473/26730000/7f39045a-47ea-11e7-8377-fc9d12b12237.gif)
   
    #### After Newly added timestamp sorter
   
    ![2501_timestamp](https://cloud.githubusercontent.com/assets/4968473/26730073/c50ea656-47ea-11e7-8c5d-db61064ca745.gif)
   
    #### After: Newly added pagination
    ![2501_pagination](https://cloud.githubusercontent.com/assets/4968473/26730130/ef173c06-47ea-11e7-9e5d-818693d3220a.gif)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2501/pagination-for-job-page

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2391
   
----
commit e604c3f3152fa2b6c22e11b0c6d875fb7960e2a6
Author: 1ambda <[hidden email]>
Date:   2017-06-02T08:32:57Z

    style: Reindent jobmanager.html

commit 49139c85b5448b006d8b240952f387a6ff05dce8
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:02:04Z

    refactor: Remove duplicated switch DOMs

commit 014943d4903328bedce8a7a12d57ac9d44989e22
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:10:31Z

    fix: Simplify job names

commit 59ddb42bbe2b9010e4547fa84410a00dc283065b
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:43:04Z

    feat: Add pagination for JOB page

commit 7f48e17fa3d884951c9bcf31c968d0e387f64e96
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:02:29Z

    fix: Better layout for jobmanager header

commit 7a6e0d0bdbcaa03e5a8fdc1723e548f5d7055df0
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:13:43Z

    fix: Remove all styles in search tools

commit ca12cd05f5eb3e52cc22c86ca5722814ebd39f61
Author: 1ambda <[hidden email]>
Date:   2017-06-02T11:00:57Z

    feat: re-style search tools

commit b0b4e52e87dd045c0d03d93df8e439383d8ebdd9
Author: 1ambda <[hidden email]>
Date:   2017-06-02T12:28:31Z

    fix: Apply interactive search

commit ae93f418ccfe5a9b44199ceec0f9efca82e96656
Author: 1ambda <[hidden email]>
Date:   2017-06-02T14:12:26Z

    feat: Add date sorter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2391

    [ZEPPELIN-2501] Better Job Navigation Experience

    ### What is this PR for?
   
    Improve UX for Job Navigation. Please refer the *TODOs* section and screenshots attached below for detail.
   
    FYI, **pagination** is added to improve page loading speed. Currently, it is going to be slow when there are 50+ jobs.
   
    ### What type of PR is it?
    [Improvement | Feature]
   
    ### Todos
    * [x] - improve UI
    * [x] - add pagination to improve page loading speed
    * [x] - interactive job searching without *enter key*
    * [x] - add date sorter
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2501](https://issues.apache.org/jira/browse/ZEPPELIN-2501)
   
    ### How should this be tested?
   
    1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. open the job page: `http://localhost:8080/#/jobmanager`
    3. try to search, filter, sort.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729918/39f51c8a-47ea-11e7-88a1-30ffa5947e3a.png)
   
    #### After: Larger UI components
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729934/48ea4c74-47ea-11e7-91f0-4aa97bb93161.png)
   
    #### After: Interactive search without enter-key
   
    ![2501_interactive](https://cloud.githubusercontent.com/assets/4968473/26730000/7f39045a-47ea-11e7-8377-fc9d12b12237.gif)
   
    #### After Newly added timestamp sorter
   
    ![2501_timestamp](https://cloud.githubusercontent.com/assets/4968473/26730073/c50ea656-47ea-11e7-8c5d-db61064ca745.gif)
   
    #### After: Newly added pagination
    ![2501_pagination](https://cloud.githubusercontent.com/assets/4968473/26730130/ef173c06-47ea-11e7-9e5d-818693d3220a.gif)
   
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2501/pagination-for-job-page

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2391
   
----
commit e604c3f3152fa2b6c22e11b0c6d875fb7960e2a6
Author: 1ambda <[hidden email]>
Date:   2017-06-02T08:32:57Z

    style: Reindent jobmanager.html

commit 49139c85b5448b006d8b240952f387a6ff05dce8
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:02:04Z

    refactor: Remove duplicated switch DOMs

commit 014943d4903328bedce8a7a12d57ac9d44989e22
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:10:31Z

    fix: Simplify job names

commit 59ddb42bbe2b9010e4547fa84410a00dc283065b
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:43:04Z

    feat: Add pagination for JOB page

commit 7f48e17fa3d884951c9bcf31c968d0e387f64e96
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:02:29Z

    fix: Better layout for jobmanager header

commit 7a6e0d0bdbcaa03e5a8fdc1723e548f5d7055df0
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:13:43Z

    fix: Remove all styles in search tools

commit ca12cd05f5eb3e52cc22c86ca5722814ebd39f61
Author: 1ambda <[hidden email]>
Date:   2017-06-02T11:00:57Z

    feat: re-style search tools

commit b0b4e52e87dd045c0d03d93df8e439383d8ebdd9
Author: 1ambda <[hidden email]>
Date:   2017-06-02T12:28:31Z

    fix: Apply interactive search

commit ae93f418ccfe5a9b44199ceec0f9efca82e96656
Author: 1ambda <[hidden email]>
Date:   2017-06-02T14:12:26Z

    feat: Add date sorter

commit 2d1b89dfd1e7fd35d9c003f7a8b6a596842d160d
Author: 1ambda <[hidden email]>
Date:   2017-06-02T14:27:01Z

    fix: Add license notation to job-status

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2391
 
    @AhyoungRyu Could you help review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2391
 
    Ready to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2391
 
    @1ambda thanks for contribution, tested and looks much better! When searching for note and clicking on it (e.g. redirect to /#/notebook/2CBFCSS6X) i can see below stacktrace in console
   
    ```
    TypeError: Cannot read property 'create' of undefined
        at Object.link (http://localhost:8080/app.6e54de3d53176984dde0.js:11:1236)
        at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:5609
        at qa (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:41840)
        at n (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:34290)
        at g (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:30249)
        at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:29780
        at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:32385
        at d (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:30743)
        at m (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:32827)
        at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:159637 <div id="{{currentParagraph.id}}_paragraphColumn_main" ng-repeat="currentParagraph in note.paragraphs" ng-controller="ParagraphCtrl" ng-init="init(currentParagraph, note)" ng-class="columnWidthClass(currentParagraph.config.colWidth)" style="margin: 0; padding: 0" viewport-watch="" class="ng-scope" data-ng-animate="1">
    ```
   
    not sure if it's related to this PR or not,  maybe we could check that. except that look good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2391
 
    @khalidhuseynov Thanks for the review. The error was fixed in a different PR. I just rebased to apply it. :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
In reply to this post by zjffdu
Github user 1ambda closed the pull request at:

    https://github.com/apache/zeppelin/pull/2391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
In reply to this post by zjffdu
GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2391

    [ZEPPELIN-2501] Better Job Navigation Experience

    ### What is this PR for?
   
    Improve UX for Job Navigation. Please refer the *TODOs* section and screenshots attached below for detail.
   
    FYI, **pagination** is added to improve page loading speed. Currently, it is going to be slow when there are 50+ jobs.
   
    ### What type of PR is it?
    [Improvement | Feature]
   
    ### Todos
    * [x] - improve UI
    * [x] - add pagination to improve page loading speed
    * [x] - interactive job searching without *enter key*
    * [x] - add date sorter
    * [x] - display total job count
   
    ### What is the Jira issue?
   
    [ZEPPELIN-2501](https://issues.apache.org/jira/browse/ZEPPELIN-2501)
   
    ### How should this be tested?
   
    1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. open the job page: `http://localhost:8080/#/jobmanager`
    3. try to search, filter, sort.
   
    ### Screenshots (if appropriate)
   
    #### Before
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729918/39f51c8a-47ea-11e7-88a1-30ffa5947e3a.png)
   
    #### After: Larger UI components
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26729934/48ea4c74-47ea-11e7-91f0-4aa97bb93161.png)
   
    #### After: Interactive search without enter-key
   
    ![2501_interactive](https://cloud.githubusercontent.com/assets/4968473/26730000/7f39045a-47ea-11e7-8377-fc9d12b12237.gif)
   
    #### After Newly added timestamp sorter
   
    ![2501_timestamp](https://cloud.githubusercontent.com/assets/4968473/26730073/c50ea656-47ea-11e7-8c5d-db61064ca745.gif)
   
    #### After: Newly added pagination
    ![2501_pagination](https://cloud.githubusercontent.com/assets/4968473/26730130/ef173c06-47ea-11e7-9e5d-818693d3220a.gif)
   
    #### Total Job Count
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26747803/55bf15a8-4833-11e7-9444-b0c69f4bd9b6.png)
   
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2501/pagination-for-job-page

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2391
   
----
commit 0ae31a01bc600ef342ba850fd29f27020e5f1373
Author: 1ambda <[hidden email]>
Date:   2017-06-02T08:32:57Z

    style: Reindent jobmanager.html

commit f8fab3f10bb4c49f1b807ae1bfcf24f2e9723f73
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:02:04Z

    refactor: Remove duplicated switch DOMs

commit 018048af11f9f76c500f928081b07c342f66090a
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:10:31Z

    fix: Simplify job names

commit 084407a1eda593d6bda8145746a190894c0dc6d9
Author: 1ambda <[hidden email]>
Date:   2017-06-02T09:43:04Z

    feat: Add pagination for JOB page

commit d7017f41c16e2a84745eef3196fa31031da002be
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:02:29Z

    fix: Better layout for jobmanager header

commit d52008e1f3352e8b6234ecd48d5ffbb30774bf27
Author: 1ambda <[hidden email]>
Date:   2017-06-02T10:13:43Z

    fix: Remove all styles in search tools

commit 081b9bb4ecae2c0491fa44b7967579b4096a04b8
Author: 1ambda <[hidden email]>
Date:   2017-06-02T11:00:57Z

    feat: re-style search tools

commit e20d1dbe1efa2dd89cfccfb36ddd7ad58e43c0f6
Author: 1ambda <[hidden email]>
Date:   2017-06-02T12:28:31Z

    fix: Apply interactive search

commit 3dd50815560b60f460de46ed0ef608a44bfbfc2c
Author: 1ambda <[hidden email]>
Date:   2017-06-02T14:12:26Z

    feat: Add date sorter

commit c5ff1f5a2fae1661d40834197aac70a9a1f2aa07
Author: 1ambda <[hidden email]>
Date:   2017-06-02T14:27:01Z

    fix: Add license notation to job-status

commit 53769661edd6945e8c854fa8d4725c62320e9ba2
Author: 1ambda <[hidden email]>
Date:   2017-06-02T23:04:14Z

    feat: Add total job count

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

zjffdu
In reply to this post by zjffdu
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2391
 
    merging if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2391: [ZEPPELIN-2501] Better Job Navigation Experienc...

zjffdu
In reply to this post by zjffdu
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2391


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---