[GitHub] zeppelin pull request #2392: [HFix] : Fix JS exception because of Zeppelin-2...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2392: [HFix] : Fix JS exception because of Zeppelin-2...

herval
GitHub user vipul1409 opened a pull request:

    https://github.com/apache/zeppelin/pull/2392

    [HFix] : Fix JS exception because of Zeppelin-2519

    ### What is this PR for?
    Fix JS exception because of Zeppelin-2519. Added the missing dependency for scroll monitor before viewport.
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2519
   
    ### How should this be tested?
    Load a notebook and you should not see any exceptions in the dev console.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vipul1409/zeppelin ZEPPELIN-2519

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2392
   
----
commit 329e33a27b28b494f739c0d569bb4ea752e9044a
Author: vipulm <[hidden email]>
Date:   2017-05-09T15:29:21Z

    Disable watchers not in viewport

commit 71425782202f57a41b41f743f6e2c0c3b1b526e8
Author: vipulm <[hidden email]>
Date:   2017-05-09T17:16:17Z

    Trigger notification

commit d698d066d186b9c3c2b0b469632c4cadf5360320
Author: vipulm <[hidden email]>
Date:   2017-05-10T06:18:34Z

    Add license file

commit 99b19a5ee018d47bc7d076f6688ef102918debc6
Author: vipulm <[hidden email]>
Date:   2017-05-11T05:51:00Z

    Move pacakg to npm

commit 175dd1768c554e97d646ed08ccdc52eba8395b06
Author: vipulm <[hidden email]>
Date:   2017-05-16T05:44:10Z

    Merge master

commit b982db4915176b718f561838c3a7163831367408
Author: vipulm <[hidden email]>
Date:   2017-05-19T05:44:48Z

    Trigger build

commit 21c03d6f9d649019f376651649b1460e64a2d93d
Author: vipulm <[hidden email]>
Date:   2017-05-21T03:40:14Z

    Merging master and resolving conflicts

commit 497413b0225c06a6b893466c391be7ed47b71d5a
Author: vipulm <[hidden email]>
Date:   2017-05-21T04:26:57Z

    Fixing build issues

commit 7cf08a610d7339674456e70e36a61d515fc8bea0
Author: vipulm <[hidden email]>
Date:   2017-06-03T00:04:44Z

    Merge branch 'master' into ZEPPELIN-2519

commit 817e6fa0e7abea355b9c3ac44462ab895c4be1cf
Author: vipulm <[hidden email]>
Date:   2017-06-03T00:05:47Z

    Fixing JS exception issue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2392: [HFix] : Fix JS exception because of Zeppelin-2519

herval
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2392
 
    Thanks @vipul1409 for the hot fix. Tested and it fixes JS exception. Merge to master as a hot fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2392: [HFix] : Fix JS exception because of Zeppelin-2...

herval
In reply to this post by herval
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2392: [HFix] : Fix JS exception because of Zeppelin-2519

herval
In reply to this post by herval
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2392
 
    @vipul1409 Thanks for the quick fix. 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...