[GitHub] zeppelin pull request #2393: [WIP][ZEPPELIN-2590] Convert jupyter's notebook...

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [WIP][ZEPPELIN-2590] Convert jupyter's notebook...

prabhjyotsingh
GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2393

    [WIP][ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin's note

    ### What is this PR for?
    Converting jupyter's notebook to Zeppelin's note
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [ ] - TBD
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2590
   
    ### How should this be tested?
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2393
   
----
commit 655cc4d7eb0a4b6790da90fffdf861d66e35ec88
Author: Jongyoul Lee <[hidden email]>
Date:   2017-05-29T08:47:58Z

    Added jupyter file format

commit a0f0c995aeb717b4291ca4d0b38fa4d5d120dbb5
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-01T15:48:43Z

    Added asf header

commit 87d200476300206b7ccc59d4ee0f6569c700034f
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:03:36Z

    Fixed typo

commit 4945f32a0ee6c9c0152b0ead372e1f22eab5820e
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:37:56Z

    Fixed style

commit 621fe1f514e01bda151d1938a4186e07502d3c91
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T06:27:22Z

    Added note format manually

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    Ready to review. Please make sure it works with latest jupyter format with major version of 4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    Yes, sure. I'll made another PR for adding docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    Made [ZEPPELIN-2616](https://issues.apache.org/jira/browse/ZEPPELIN-2616)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
GitHub user jongyoul reopened a pull request:

    https://github.com/apache/zeppelin/pull/2393

    [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin's note

    ### What is this PR for?
    Converting jupyter's notebook to Zeppelin's note
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [x] - Add command line interface
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2590
   
    ### How should this be tested?
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2393
   
----
commit 655cc4d7eb0a4b6790da90fffdf861d66e35ec88
Author: Jongyoul Lee <[hidden email]>
Date:   2017-05-29T08:47:58Z

    Added jupyter file format

commit a0f0c995aeb717b4291ca4d0b38fa4d5d120dbb5
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-01T15:48:43Z

    Added asf header

commit 87d200476300206b7ccc59d4ee0f6569c700034f
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:03:36Z

    Fixed typo

commit 4945f32a0ee6c9c0152b0ead372e1f22eab5820e
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:37:56Z

    Fixed style

commit 621fe1f514e01bda151d1938a4186e07502d3c91
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T06:27:22Z

    Added note format manually

commit 4e4cfda00a60f08f3e232447228e0a7aa0294331
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T16:38:48Z

    Added command line interface

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul closed the pull request at:

    https://github.com/apache/zeppelin/pull/2393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
GitHub user jongyoul reopened a pull request:

    https://github.com/apache/zeppelin/pull/2393

    [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin's note

    ### What is this PR for?
    Converting jupyter's notebook to Zeppelin's note
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [x] - Add command line interface
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2590
   
    ### How should this be tested?
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2393
   
----
commit 655cc4d7eb0a4b6790da90fffdf861d66e35ec88
Author: Jongyoul Lee <[hidden email]>
Date:   2017-05-29T08:47:58Z

    Added jupyter file format

commit a0f0c995aeb717b4291ca4d0b38fa4d5d120dbb5
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-01T15:48:43Z

    Added asf header

commit 87d200476300206b7ccc59d4ee0f6569c700034f
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:03:36Z

    Fixed typo

commit 4945f32a0ee6c9c0152b0ead372e1f22eab5820e
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:37:56Z

    Fixed style

commit 621fe1f514e01bda151d1938a4186e07502d3c91
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T06:27:22Z

    Added note format manually

commit 4e4cfda00a60f08f3e232447228e0a7aa0294331
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T16:38:48Z

    Added command line interface

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul closed the pull request at:

    https://github.com/apache/zeppelin/pull/2393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    @felixcheung Thanks for the review. I'll fix somethings and will remain others for the community. I think there's Python expert in the community and they will help to improve this feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    @cloverhearts Can you tested it? I've pushed some commit and deployed it to snapshots. And also please test it with v3 format :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    @jongyoul Thank you, I am currently checking. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    Passed. https://travis-ci.org/jongyoul/zeppelin/builds/241524191


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul closed the pull request at:

    https://github.com/apache/zeppelin/pull/2393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
GitHub user jongyoul reopened a pull request:

    https://github.com/apache/zeppelin/pull/2393

    [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin's note

    ### What is this PR for?
    Converting jupyter's notebook to Zeppelin's note
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [x] - Add command line interface
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2590
   
    ### How should this be tested?
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2393
   
----
commit 655cc4d7eb0a4b6790da90fffdf861d66e35ec88
Author: Jongyoul Lee <[hidden email]>
Date:   2017-05-29T08:47:58Z

    Added jupyter file format

commit a0f0c995aeb717b4291ca4d0b38fa4d5d120dbb5
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-01T15:48:43Z

    Added asf header

commit 87d200476300206b7ccc59d4ee0f6569c700034f
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:03:36Z

    Fixed typo

commit 4945f32a0ee6c9c0152b0ead372e1f22eab5820e
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-02T02:37:56Z

    Fixed style

commit 621fe1f514e01bda151d1938a4186e07502d3c91
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T06:27:22Z

    Added note format manually

commit 4e4cfda00a60f08f3e232447228e0a7aa0294331
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-04T16:38:48Z

    Added command line interface

commit bd5fbdc024097c634688256409ac69b2eee7f11d
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-09T06:48:15Z

    Removed unused spaces

commit e4d9ff3d9ee884e80915916e19043763eeb8aac6
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-09T06:51:56Z

    Called close method for inputStream
    Refactored gson logic

commit ac115b2c9a20dfada2df75f48606aba20fb71425
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-09T07:28:58Z

    Added object to support v3

commit 794e3215f0d0dce4a1f4346db80dea953e9e4f36
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-09T07:31:56Z

    Fixed the style

commit a653aeae06008a3df601fba7448299e1a5bc606c
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-10T13:54:12Z

    Changed replaced string to contain "%"

commit ac89aa695cfc402390dd858b88ca45f324fd4ce8
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-10T14:26:12Z

    Added AL header

commit 45c1ec80eb66034c64d3d114157086be7659dc99
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-10T14:28:53Z

    Fixed the tests

commit b6a50a2b2e734f189ddbb999b740ab770ce3de8b
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-12T05:39:26Z

    Added getters

commit 30e970dc6a235718b35efeefa835a20d1c1b2872
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-12T14:11:37Z

    Added getters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2393
 
    Merging if there's no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Z...

prabhjyotsingh
In reply to this post by prabhjyotsingh
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---