[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...

classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...

soralee
GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2394

    [gh-pages] [ZEPPELIN-2597] adding technologies and deployments (Main Page)

    ### What is this PR for?
    This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage.
    To sum up, Technologies section is consist of 3 interpreters most people search or want (already talking about this on the mailing list.) and, Deployments section describes single or multiple user setting.
   
   
    ### What type of PR is it?
    [Improvement]
   
   
    ### What is the Jira issue?
    * [ZEPPELIN-2597](https://issues.apache.org/jira/browse/ZEPPELIN-2597)
   
   
    ### How should this be tested?
    1. run `bundle exec jekyll serve --watch` in this branch
    2. open `localhost:4000`
   
   
    ### Screenshots (if appropriate)
    - Look `Technologies` and `Deployments` sections
    ![peek 2017-06-05 15-14](https://cloud.githubusercontent.com/assets/8110458/26772663/d5ba7cbe-4a01-11e7-8715-03569d00509a.gif)
   
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, this is.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin adding_technologies_and_deployments

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2394
   
----
commit b8105cd3c09a8c2b56e190a4e18fb64a2c7b114d
Author: soralee <[hidden email]>
Date:   2017-06-05T06:08:14Z

    adding technologies and deployments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @AhyoungRyu @1ambda @Leemoonsoo, please review again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    I think it would be better if the font sizes inside top box(technologies) and bottom(deployments) were of same size and had a uniform margin / padding scheme. Also about **use now** and **learn more** buttons


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    7. Improve layout for mobile browsers.
   
    7-1. each `panel-content` in the **TECHNOLOGIES** section doesn't have margin-top or bottom. It's not consistent compared to `panel-content-user` in  the **DEPLOYMENTS** section.
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26777399/036b2864-4a18-11e7-95a1-f6bc2b976236.png)
   
    7-2. It would be nice to add `padding-left` and `padding-left` to `.advertise` (30px might be proper.)
   
    ### Current
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26777452/44b842ac-4a18-11e7-8439-5af3cde788b8.png)
   
    ### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26777440/346535fe-4a18-11e7-9bd6-780b15fbffbe.png)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @sravan-s, I've fixed to match font size as your mention. Regarding of `uniform margin / padding scheme` I tried to fit the box ratio. could you check this if you have time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @1ambda , I've update regarding of  `7.Improve layout for mobile browsers.` could you confirm, again?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    11. Adjustment margin among components
   
    - `padding-bottom: 30px` for `.tech_deploy h2`
    - remove the css `tech_deploy` class in `technologies_deployments.md` LINE16: `tech_deploy container` -> `container`
    - `padding-top: 22px` and `padding-bottom: 40px` for `.tech_deploy`
    - remove `padding-bottom` and `margin-top` in `technologies_deployments.md: LINE 52`
    - remove `padding-bottom` and `padding-top` in the `.tech_deploy p` class. (DON'T SET to 0, just remove the style)
    - `margin-top: 25px`, `margin-bottom: 30px` for `.tech_deploy p`
    - inline style `padding-bottom: 8px;` for **DEPLOYMENTS** `h2`
   
    ### Current
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26810862/016a8956-4aa9-11e7-8f8a-d8e6a1d13f7c.png)
   
    ### After
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26810957/bd8cb5f0-4aa9-11e7-9cda-79d2b99ac127.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    Thanks for your great effort @soralee. LGTM! except
   
    * [ ] - comments 4
    * [ ] - comments 8
    * [ ] - comments 9-1, 9-2, 9-3
    * [ ] - comments 10
    * [ ] - comments 11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    I really thank @1ambda and  your a kind explanation as well!
    I'll update the following list and let you know that.
    ```
     - comment 4 (SQL text font styling)
     - comment 8
     - comments 9-1, 9-2, 9-3
     - comment 10
     - comment 11
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @1ambda, I just finished the list about all your comment.
    For help to easy your review, I involved comment numbers in title message when I commit.
    I appreciate for taking care of this PR, all detailed comment as well!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    some improving list
    - arranged to same line each 'use now' button in the Technologies.
    - changed contents font style in Technologies and Deployments.
    - removed bold font of buttons in the Deployments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    LGTM.
   
    ## Chrome on OSX
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26826728/0f6df730-4af5-11e7-914f-9154b5e8ca87.png)
   
    ## Safari on OSX
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26826748/20c1f842-4af5-11e7-8cac-d187b3a8102a.png)
   
    ## Old version Firefox (v31) on OSX
   
    ![image](https://cloud.githubusercontent.com/assets/4968473/26826771/33cc509a-4af5-11e7-9bfa-f9fd4867b48b.png)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @1ambda Thanks a lots of! you're the best! :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    Thanks for the great work @soralee! And also thanks for detailed review @1ambda.
    Tested and looks nice!
    I really like the most of parts. Some minor suggestion is
   
    #### Technologies
     - how about using same border color with "Deployment" box `#999` instead of `#4881B3`?
    <img width="997" alt="screen shot 2017-06-06 at 7 36 05 pm" src="https://user-images.githubusercontent.com/10060731/26859880-7f3df818-4aef-11e7-9364-a0274c2642bf.png">
   
    #### Deployment
     -  how about putting "LEARN MORE" buttons in each deployment section box in the middle instead of right side?
     - and also we can remove the single & multi user font awesome icons since the text ("single" and "multi") itself already explain what "single-user" and "multi-user" are meaning for.
   
    How about this? It's just my opinion. Please have a look and feel free to share your thought :)
   
    <img width="990" alt="screen shot 2017-06-06 at 7 25 45 pm" src="https://user-images.githubusercontent.com/10060731/26859800-0d9d5cf8-4aef-11e7-804c-3f93a1ae035d.png">
   
   
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @AhyoungRyu, Thanks for review and suggestions!
    Sure, I can change the border color in Technologies section and, I can remove icons in Deployments section.
   
    IMO, about Deployments section, actually the current structure is good to me (including icons).
    And especially the buttons, it would be better to keep the current structure to match the buttons in the above technologies.
   
    ![screenshot from 2017-06-07 12-03-09](https://user-images.githubusercontent.com/8110458/26860704-5625eab8-4b7a-11e7-8f04-a9b509b8ab8c.png)
   
    How about this? :slightly_smiling_face:
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    or to decorate in Deployments section, How about this structure?
   
    ![image](https://user-images.githubusercontent.com/8110458/26861081-70ce8f80-4b7c-11e7-881d-c7fa9e6d95c5.png)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    Yeah second option is better for me :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @AhyoungRyu, Thanks for accepting :+1:
    Let me improve this and let you know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @soralee , sorry, I am having some trouble installing jekyll and stuff in my machine, but your screenshots looks good :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2394
 
    @AhyoungRyu I updated as your mentions.
    ![image](https://user-images.githubusercontent.com/8110458/26912241-117e2a68-4c4e-11e7-9827-6ee01e514ad3.png)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...