[GitHub] zeppelin pull request #2399: [ZEPPELIN-2620] fa-area chart cannot be resized...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2399: [ZEPPELIN-2620] fa-area chart cannot be resized...

zjffdu
GitHub user 0qtttt opened a pull request:

    https://github.com/apache/zeppelin/pull/2399

    [ZEPPELIN-2620] fa-area chart cannot be resized smaller

    ### What is this PR for?
    fix chart resizing
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
    * [ ] - Chart Resize Bug Fix
   
    ### What is the Jira issue?
    [[ZEPPELIN-2620]](https://issues.apache.org/jira/browse/ZEPPELIN-2620)
   
    ### How should this be tested?
    yarn run dev
   
    ### Screenshots (if appropriate)
    before
    ![3](https://user-images.githubusercontent.com/20390348/26860178-8226043e-4b77-11e7-823a-c319940e2e21.gif)
   
    after
    ![1-capture](https://user-images.githubusercontent.com/20390348/26860193-988be702-4b77-11e7-9b81-fd68f37242e8.gif)
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/0qtttt/zeppelin branch-0.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2399
   
----
commit 9886340b2541908703f10ad253b34927ba107c7a
Author: ygpark <[hidden email]>
Date:   2017-06-07T02:30:08Z

    [ZEPPELIN-2620] fa-area chart cannot be resized smaller

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2399: [ZEPPELIN-2620] fa-area chart cannot be resized smalle...

zjffdu
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2399
 
    Thanks @0qtttt for the contribution.
    I tested `master` branch and `branch-0.7` but i didn't see the problem.
   
    @0qtttt could you confirm that the problem exists on current `master` or `branch-0.7`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2399: [ZEPPELIN-2620] fa-area chart cannot be resized smalle...

zjffdu
In reply to this post by zjffdu
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2399
 
    Failed to reproduce branch-0.7 using chrome edge on OSX.
   
    - 1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    - 2. open browser `localhost:8080`
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2399: [ZEPPELIN-2620] fa-area chart cannot be resized smalle...

zjffdu
In reply to this post by zjffdu
Github user 0qtttt commented on the issue:

    https://github.com/apache/zeppelin/pull/2399
 
    @1ambda I'll check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...