[GitHub] zeppelin pull request #2404: fix bugs for: when interpreter setting start, a...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2404: fix bugs for: when interpreter setting start, a...

zjffdu
GitHub user wary opened a pull request:

    https://github.com/apache/zeppelin/pull/2404

    fix bugs for: when interpreter setting  start, all user running aborted

    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
   
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
     [ZEPPELIN-2638] (https://issues.apache.org/jira/browse/ZEPPELIN-2638)
   
    ### How should this be tested?
    context:
    running zeppelin in multi user environment and the option of the spark interpreter is
    "The interpreter will be instantiated Per User in isolated process";
   
    before fix:
    when one user restart spark interpreter on his note configuration page,all running jobs of other users has also been aborted
   
    after fix:
    when one user restart spark interpreter on his note configuration page,only the running jobs of the user who restart interpreter  aborted, there is no impact to the jobs of other users
   
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wary/zeppelin bugs-fix-interpreter-restart

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2404
   
----
commit fad3348a64e38d63a6ff6e988960ac6b994ef815
Author: lei wang <[hidden email]>
Date:   2017-06-11T07:54:50Z

    fix bugs for: when interpreter setting  start, all user running aborted

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    Hi, It's intended behaviours. If you want to restart your interpreter only, you can click the restart button on the note page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
In reply to this post by zjffdu
Github user wary commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    @jongyoul  sorry for vague description,  "his note configuration page" means "note page"; when some one restart interpreter on note page, the running jobs of others  has also been aborted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    @wary Thanks for additional description. Let's check it. It's very fragile part of Apache Zeppelin for now. Did you test other behaviors related this features?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
In reply to this post by zjffdu
Github user wary commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    @jongyoul  Yes, this bug has been fixed for a month in our team (six analyst and sex data developer), it's running very well in this part


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
In reply to this post by zjffdu
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    Let me test it. I wonder if it works when we restart Zeppelin itself or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

zjffdu
In reply to this post by zjffdu
Github user wary commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
 
    @jongyoul  thx for testing my code, any question, please feel free to let me know, thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2404: fix bugs for: when interpreter setting restart ...

zjffdu
In reply to this post by zjffdu
Github user wary closed the pull request at:

    https://github.com/apache/zeppelin/pull/2404


---