[GitHub] zeppelin pull request #2413: [ZEPPELIN-2654] add roles to permissions of int...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2413: [ZEPPELIN-2654] add roles to permissions of int...

soralee
GitHub user tinkoff-dwh opened a pull request:

    https://github.com/apache/zeppelin/pull/2413

    [ZEPPELIN-2654] add roles to permissions of interpreter

    ### What is this PR for?
    Added the ability to specify roles (groups) which is available to use an interpreter (тow it is possible to set permissions to users only). The same solution as permissions of notes.
   
    ### What type of PR is it?
    Improvement
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2654
   
    ### How should this be tested?
    1. Create note with Interpreter (for ex. spark)
    2. Set permissions to Interpreter (spark) for `role1`
    3. Log in by user with role `role1` and open note (from item 1)
    4. Run paragraph
    ``` println("test")```
    **Result == test**
    6. Logout
    7. Log in by user without role `role1` and open note (form item 1)
    8.  Run paragraph
    ``` println("test")```
    **Result == "...no permissions..."**
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2654

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2413
   
----
commit f4ed56d7b575b8a2b7f8351f8b2280b94b2ae6de
Author: Tinkoff DWH <[hidden email]>
Date:   2017-06-15T11:25:42Z

    [ZEPPELIN-2654] add roles to permissions of interpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2413: [ZEPPELIN-2654] add roles to permissions of interprete...

soralee
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2413
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2413: [ZEPPELIN-2654] add roles to permissions of interprete...

soralee
In reply to this post by soralee
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2413
 
    LGTM and merge to master if no further discussions!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2413: [ZEPPELIN-2654] add roles to permissions of int...

soralee
In reply to this post by soralee
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2413


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...