[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalize mode action

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalize mode action

soralee
GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2415

    [ZEPPELIN-2661] Test: personalize mode action

    ### What is this PR for?
    Adding to personalized mode action case on Selenium test.
    Here is for checking scenario.
   
    1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout.
               > checkpoint : result of paragraph is 'Before'.
   
    2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout.
               > checkpoint 1 : enabling personalized mode
               > checkpoint 2 : result of paragraph is 'Before'.
   
    3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout.
               > checkpoint : changed from 'Before' to 'After' in paragraph result.
   
    4. (user1) login, check whether result of paragraph is 'Before' or not.
               > checkpoint : result of paragraph is 'Before', 'After' means test fail.
   
   
    ### What type of PR is it?
    [ Test ]
   
   
    ### What is the Jira issue?
    * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661)
   
    ### How should this be tested?
    - build zeppelin with `mvn clean package -DskipTests'
    - execute `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testGroupPermission`
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin personalize_mode_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
   
----
commit 5f7788f4fca2c82ded2cec1f189bdc99e144e53b
Author: soralee <[hidden email]>
Date:   2017-06-16T03:32:27Z

    personalize mode integration test

commit b5c2a435c07f7ee9ca415fe42375e301950fb66a
Author: soralee <[hidden email]>
Date:   2017-06-16T05:34:02Z

    test: add to check point about being turned on personalized mode in user1

commit 2aa3e6d468de8c624396fe4337ed765cc82b0586
Author: soralee <[hidden email]>
Date:   2017-06-16T05:41:43Z

    style: added new line

commit c14de44743f877ea554d1fe4baff4e97d866fe9a
Author: soralee <[hidden email]>
Date:   2017-06-16T06:15:23Z

    style: [minor] modify annotation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalize mode action

soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    @jongyoul @1ambda please help to review :slightly_smiling_face:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    Could you make CI green?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    reopen for CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee closed the pull request at:

    https://github.com/apache/zeppelin/pull/2415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/2415

    [ZEPPELIN-2661] Test: personalized mode action

    ### What is this PR for?
    Adding to personalized mode action case on Selenium test.
    Here is for checking scenario.
   
    1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout.
               > checkpoint : result of paragraph is 'Before'.
   
    2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout.
               > checkpoint 1 : enabling personalized mode
               > checkpoint 2 : result of paragraph is 'Before'.
   
    3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout.
               > checkpoint : changed from 'Before' to 'After' in paragraph result.
   
    4. (user1) login, check whether result of paragraph is 'Before' or not.
               > checkpoint : result of paragraph is 'Before', 'After' means test fail.
   
   
    ### What type of PR is it?
    [ Test ]
   
   
    ### What is the Jira issue?
    * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661)
   
    ### How should this be tested?
    - build zeppelin with `mvn clean package -DskipTests'
    - execute `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testGroupPermission`
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin personalize_mode_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
   
----
commit 5f7788f4fca2c82ded2cec1f189bdc99e144e53b
Author: soralee <[hidden email]>
Date:   2017-06-16T03:32:27Z

    personalize mode integration test

commit b5c2a435c07f7ee9ca415fe42375e301950fb66a
Author: soralee <[hidden email]>
Date:   2017-06-16T05:34:02Z

    test: add to check point about being turned on personalized mode in user1

commit 2aa3e6d468de8c624396fe4337ed765cc82b0586
Author: soralee <[hidden email]>
Date:   2017-06-16T05:41:43Z

    style: added new line

commit c14de44743f877ea554d1fe4baff4e97d866fe9a
Author: soralee <[hidden email]>
Date:   2017-06-16T06:15:23Z

    style: [minor] modify annotation

commit 92b3a6f6eb09c730a8a5440dd1f5372ddcc073ec
Author: soralee <[hidden email]>
Date:   2017-06-16T06:34:26Z

    style: modify method name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    @1ambda, changed some code so that using minimum `sleep` method. I tried to change all sleep, but I checked If changing page, it needed a little `sleep`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    reopen for CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee closed the pull request at:

    https://github.com/apache/zeppelin/pull/2415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/2415

    [ZEPPELIN-2661] Test: personalized mode action

    ### What is this PR for?
    Adding to personalized mode action case on Selenium test.
    Here is for checking scenario.
   
    1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout.
               > checkpoint : result of paragraph is 'Before'.
   
    2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout.
               > checkpoint 1 : enabling personalized mode
               > checkpoint 2 : result of paragraph is 'Before'.
   
    3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout.
               > checkpoint : changed from 'Before' to 'After' in paragraph result.
   
    4. (user1) login, check whether result of paragraph is 'Before' or not.
               > checkpoint : result of paragraph is 'Before', 'After' means test fail.
   
   
    ### What type of PR is it?
    [ Test ]
   
   
    ### What is the Jira issue?
    * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661)
   
    ### How should this be tested?
    - build zeppelin with `mvn clean package -DskipTests'
    - execute `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testActionPersonalizedMode`
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin personalize_mode_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
   
----
commit 38e467c12397985303af372d6bd98319fdc93bdf
Author: soralee <[hidden email]>
Date:   2017-06-16T03:32:27Z

    personalize mode integration test

commit 2752104cc3ee46dd7b1b17a4551fbe7b773c007e
Author: soralee <[hidden email]>
Date:   2017-06-16T05:34:02Z

    test: add to check point about being turned on personalized mode in user1

commit 2ddfd8cbbfb1a874fb5e4f9857bc51d9ef986c06
Author: soralee <[hidden email]>
Date:   2017-06-16T05:41:43Z

    style: added new line

commit 8d17a64c5af9bb6b7ef0551b5e7f981a97fb1596
Author: soralee <[hidden email]>
Date:   2017-06-16T06:15:23Z

    style: [minor] modify annotation

commit 8690eb28144f4c70ba9b28b20cac60be0ece42ab
Author: soralee <[hidden email]>
Date:   2017-06-16T06:34:26Z

    style: modify method name

commit 7d9be043bc3101198fcf7fa434b7c3b540fa0ecc
Author: soralee <[hidden email]>
Date:   2017-06-19T08:56:14Z

    fix: using minimum 'sleep' method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    Generally looks good. This PR is for testing the basic personalized mode behavior what we should have to verify before every release.
   
    AFAIK, outputs are personalized for
   
    - graph (e.g changing graph type)
    - dynamic forms
   
    Can we make the similar tests for these cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    @1ambda Thanks for review and Sounds good!
    Let me make two scenarios which is based above code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    Hi, there.
    I just added two test cases as the @1ambda comment and have written PR description as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

soralee
In reply to this post by soralee
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    Simple action test LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

soralee
In reply to this post by soralee
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    We'd better divide this test into two or three issues as it's not passed by some minor bugs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

soralee
In reply to this post by soralee
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    Could we run it many times to make sure this is not flaky test ? Sadly, I see flaky test in selenium test very often.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

soralee
In reply to this post by soralee
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2415
 
    @jongyoul sounds good!
    I'll created JIRA ticket to improve personalized mode and test, after merge.
   
    @zjffdu in my local, it works very well. and even my CI is failing other selenium. one thing, I can test in Travis many times. so let me test more on Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...