[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

asfgit
GitHub user yu74n opened a pull request:

    https://github.com/apache/zeppelin/pull/2416

    [ZEPPELIN-2647] Set admin user as owner when user create a notebook

    ### What is this PR for?
    When a user creates a notebook, default users (an administrator can set default users in zeppelin-site.xml) are set as owner.
   
    ### What type of PR is it?
    Improvement
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2647
   
    ### How should this be tested?
    1. Change Notebook workspace to private through whether ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
    2. Set default owners through ZEPPELIN_DEFAULT_OWNER = <comma separated username> or zeppelin.notebook.owner = <comma separated username>.
    3. Create notebook.
    4. Check if notebook's owner is set to both default users and the user who create the notebook.
   
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? Y/N
    * Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yu74n/zeppelin default-owner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2416
   
----
commit ec5faa911cf7c2e725a09ecf792348baaa536d24
Author: Yuta Hongo <[hidden email]>
Date:   2017-06-16T05:41:27Z

    Add new setting field to set default owner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

asfgit
Github user yu74n closed the pull request at:

    https://github.com/apache/zeppelin/pull/2416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

asfgit
In reply to this post by asfgit
GitHub user yu74n reopened a pull request:

    https://github.com/apache/zeppelin/pull/2416

    [ZEPPELIN-2647] Set admin user as owner when user create a notebook

    ### What is this PR for?
    When a user creates a notebook, default users (an administrator can set default users in zeppelin-site.xml) are set as owner.
   
    ### What type of PR is it?
    Improvement
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2647
   
    ### How should this be tested?
    1. Change Notebook workspace to private through whether ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
    2. Set default owners through ZEPPELIN_DEFAULT_OWNER = <comma separated username> or zeppelin.notebook.owner = <comma separated username>.
    3. Create notebook.
    4. Check if notebook's owner is set to both default users and the user who create the notebook.
   
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? Y/N
    * Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yu74n/zeppelin default-owner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2416
   
----
commit ec5faa911cf7c2e725a09ecf792348baaa536d24
Author: Yuta Hongo <[hidden email]>
Date:   2017-06-16T05:41:27Z

    Add new setting field to set default owner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

asfgit
In reply to this post by asfgit
Github user bhavintandel commented on the issue:

    https://github.com/apache/zeppelin/pull/2416
 
    Have you guys planned to merge this request anytime soon ? If Yes, for which release have you planned


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2416
 
    @yu74n Could you resolve conflict and check my last comment? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2416
 
    @bhavintandel I haven't checked this can be merged into the 0.7 branch. But if there is no problem to merge, and we can include this PR in 0.7.3
   
    - even if there's conflict, we can create a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

asfgit
In reply to this post by asfgit
Github user yu74n commented on the issue:

    https://github.com/apache/zeppelin/pull/2416
 
    @1ambda I created new PR for this issue. Could you check the new one?
    I will close the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...