[GitHub] zeppelin pull request #2418: [ZEPPELIN-2645] Adding way to register RemoteIn...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2418: [ZEPPELIN-2645] Adding way to register RemoteIn...

herval
GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2418

    [ZEPPELIN-2645] Adding way to register RemoteInterpreterServer's port into InterpreterProcess

    ### What is this PR for?
    This is a thrift version related to #2410
   
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [x] - Add opposite set of server/client
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2645
   
    ### How should this be tested?
    N/A
   
    ### Screenshots (if appropriate)
    N/A
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2645-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2418
   
----
commit b5f1816a65ff217c4eef6439c0084f12e3aab601
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-14T10:43:49Z

    Added getters

commit e0af12abcc79ecf164a40b647ea5f4fcff91f35a
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-14T13:23:10Z

    changed constructor for ZeppelinDevServer

commit 82236fba457db849c63c1d02ec2a1aa1d6718526
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-17T00:44:23Z

    Shaded netty-all dependencies into zeppelin-interpreter

commit dddd9234d28139c4353fe5b74af17d0f1aaca84b
Author: Jongyoul Lee <[hidden email]>
Date:   2017-06-17T10:47:01Z

    Changed netty to thrift

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

herval
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2418
 
    @jongyoul Thanks for the PR.
    1. It looks there will be one server per RemoterInterpreterProcess, will it been shutdown after it get the port and host info ? And what will happens if the interpreter process fails to launch ?
    2. What is the advantage of netty over thrift ? Since this relates with the how we communicate between zeppelin server and interpreter process, we need to consider which one is better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

herval
In reply to this post by herval
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2418
 
    @jongyoul I think there's 2 follow up things to do.
    * Unify the communication frame between zeppelin server & interpreter process.
    * Change the pull mode to push mode so that interpreter process can push data to zeppelin-server.
   
    When we consider to choose netty or thrift, we need to consider these 2 things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

herval
In reply to this post by herval
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2418
 
    @zjffdu Agreed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...