[GitHub] zeppelin pull request #2462: ZEPPELIN-2527 Changed editor cursor to thin

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
GitHub user malayhm opened a pull request:

    https://github.com/apache/zeppelin/pull/2462

    ZEPPELIN-2527 Changed editor cursor to thin

    ### What is this PR for?
    Previously, it's hard to recognize the cursor since it was too thick. After this PR, it will show the cursor same as other input boxes for consistency.
   
    See the attached GIFs for comparison.
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2527
   
    ### How should this be tested?
   
    1. Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
    2. Open a paragraph
    3. Check the cursor
   
    ### Screenshots (if appropriate)
    Before
    ![cursor-change-pr-before](https://user-images.githubusercontent.com/1881135/27830832-cd55ec8e-60e5-11e7-8a0e-f75caecaba30.gif)
   
    After
    ![cursor-change-pr](https://user-images.githubusercontent.com/1881135/27830837-d01fba30-60e5-11e7-8722-8056f7abaebc.gif)
   
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/malayhm/zeppelin ZEP-2527

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2462
   
----
commit e45f23b3a0acb7f05c4d559d7abf319a125549e3
Author: Malay Majithia <[hidden email]>
Date:   2017-07-04T12:50:50Z

    ZEPPELIN-2527 Changed editor cursor to thin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Thanks for the contribution @malayhm. I left a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    ping @malayhm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Hi, @malayhm Could you take a look the comment I left? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user malayhm commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    All the comments are taken care of, if there are no more comments, could we merge this PR to master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    @malayhm cursor is still thick. Should I missing something? or..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user malayhm commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    @1ambda I have changed the fix and also verified it. It should show the thin cursor with latest changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user malayhm commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Updated screenshot:
   
    ![cursor-change-pr-after](https://user-images.githubusercontent.com/1881135/28693294-cb29f036-72d8-11e7-8029-511301b70209.gif)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user malayhm commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Screenshot with the latest change:
   
    ![cursor-change-pr-after-2px](https://user-images.githubusercontent.com/1881135/28850207-548e2f86-76e9-11e7-9fc9-0498f4b7ac0b.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Great!
   
    LGTM, let's merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user malayhm commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    Should we merge this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2462
 
    @malayhm Merged to master. Thanks for the contribution again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...