[GitHub] zeppelin pull request #2484: [ZEPPELIN-2711] [WIP] basic metrics for paragra...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2484: [ZEPPELIN-2711] [WIP] basic metrics for paragra...

asfgit
GitHub user herval opened a pull request:

    https://github.com/apache/zeppelin/pull/2484

    [ZEPPELIN-2711] [WIP] basic metrics for paragraphs & notebook view/create/run

    ### What is this PR for?
   
    This exposes JMX metrics for a few operations on Zeppelin. The first step here is to expose them via JMX, then later introduce a JSON endpoint (which would make it easier to integrate these metrics on common monitoring systems such as Prometheus, Graphite, Influx, etc
   
    I'm putting this out as WIP before finishing the tests & JSON bits in order to kick-off any design discussion and address comments sooner than later
   
    ### What type of PR is it?
    Feature
   
    ### Todos
    * [ ] - Tests
    * [ ] - JSON endpoint
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2711
   
    ### How should this be tested?
    TODO
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?
    Yes
   
    * Is there breaking changes for older versions?
    No
   
    * Does this needs documentation?
    Yes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/herval/zeppelin metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2484
   
----
commit 41bfbe3adf3b6a99c8b8794ae225ec68e98b5848
Author: Herval Freire <[hidden email]>
Date:   2017-07-11T00:21:50Z

    basic metrics for paragraphs & notebook view/create/run

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
Github user herval commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    This is the basic set of functionality needed to start monitoring some common metrics - Comments & observations welcome!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
In reply to this post by asfgit
Github user herval commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    Hi folks - any thoughts on this approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    Apologies for late response. @herval It looks great.
   
    While this PR adds dependencies,
   
    ```
    [INFO] +- org.weakref:jmxutils:jar:1.9:compile
    [INFO] +- org.hdrhistogram:HdrHistogram:jar:2.1.4:compile
    ```
   
    We'll need add their license into `https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE`. Could you update license file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
In reply to this post by asfgit
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    Hi, I have a simple question. AFAIK, dropwizard metrics are more popular and have powerful features. Have you consider it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
In reply to this post by asfgit
Github user herval commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    @jongyoul good q. I tried another stats libraries I've seen used around (airlift), but had a hard time reconciling dependencies, so went with the smallest footprint one + implementing the servlet myself. It looks like metrics-core is [pretty self contained too](https://mvnrepository.com/artifact/com.codahale.metrics/metrics-core/3.0.2) - I'd be fine giving it a try, if folks prefer it for some reason (I'm honestly not super up-to-speed on what's popular these days, so I'm glad to defer this decision :-))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...

asfgit
In reply to this post by asfgit
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2484
 
    Agreed. we can improve this feature after adopting one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...