[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

asfgit
GitHub user sanjaydasgupta opened a pull request:

    https://github.com/apache/zeppelin/pull/2502

    [ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967)

   
    ### What is this PR for?
    This feature allows embedding/interpolating Z variables into SQL statements passed to the Spark-SQL interpreter. It implements one part of the functions desired by the pre-existing issue (ZEPPELIN-1967)
   
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2807
   
    ### How should this be tested?
    A new test has been added to the unit tests. The attached screenshot also shows tests of the functionality.
   
    ### Screenshots (if appropriate)
    ![sparksqlchange](https://user-images.githubusercontent.com/477015/28521954-a1148532-7093-11e7-85e8-293d86fb0362.png)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, a small update to any existing documentation is ideal.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaydasgupta/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2502
   
----
commit e8ba58a94743b743f2a05cef8b9755d5bf79510c
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-24T11:29:29Z

    ZEPPELIN-2807: Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Thank you for the observations @felixcheung.
    Will review these points and make suitable changes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    The choice of {...} for identifying parameter/variable names comes from the parent issue [ZEPPELIN-1967](https://issues.apache.org/jira/browse/ZEPPELIN-1967). Though #{...} seems more widely used in other settings and languages, I have no opinion in the matter, and would like to request the original issue's author @Tagar to offer any comments. Thanks for your ideas and help with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    @sanjaydasgupta great job on getting this done.
    ZEPPELIN-1967 was inspired by Jupyter so I just we should do the same as it is done there.
    So it's less confusing for users who are switching from Jupyter.
    I would suggest not to use #{...} as it'll be confusing to use this naming convention in shell interpreter, for example.
    Escaping should be done similarly like in Jupyter.
    With double curly braces –
    {{ will be escaped to single left curly brace - {
    }} will be escaped to single right curly brace - }
    Thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    I would like your views @felixcheung @zjffdu @Tagar on the following approach to escaping and regex errors etc:
   
    I wish to suggest that no escaping is needed, as the substitution code kicks in only when 2 conditions are met: (1) the pattern {...} exists in the command, and (2) the variable named in {...} actually has a mapping in Z. If the second condition is not met, because a prior z.put(...) has not been executed for the same variable name, the original command including the {...} is left unchanged. Since the variable name used is expected to be meaningful, and is entirely under the end-user's control, it is always possible to avoid the need for escaping. Leaving the original command unchanged has other utilities as shown in the examples below.
   
    **Setup**
    ```
    val df = spark.createDataFrame(Seq((1, "one"), (3, "three"),
        (Int.MaxValue / 2, "##"), (Int.MaxValue, "####"))).toDF("id", "name")
    df.createOrReplaceTempView("name")
   
    z.put("n", 3)
    z.put("table", "name")
    ```
    **Trivial Case**
    The following SQL command works _normally_ -- performing variable substitution as expected.
    `%sql select * from {table} where id = {n}`
    The output has one row: (3, three)
   
    **Unchanged Pattern-Like Construction**
    But the following command also works -- with the pattern-like structure (which is actually a regex passed to _regex_) left unchanged.
    `%sql select * from {table} where name rlike '#{2}'`
    The output has 2 rows: (1073741823, ##) and (2147483647, ####)
   
    Note that allowing substitution patterns inside quotes is an advantage, giving us a string-interpolation facility like in Scala (and other languages). Again, escaping is not required here also as long as the content of {...} is judiciously chosen.
   
    **One Last Example**
    The following example has two {...} structures, the first is part of a regex, the second is a real pattern.
    ```
    z.put("what", "e")
    %sql select * from {table} where name rlike '^.{3}{what}.$'
    ```
    The output has one row: (3, three)
   
    Incomplete patterns are also left unchanged, this could be an advantage for future embedded mini-languages in the same scope.
   
    Would like to hear your views on the this proposal to not implement escapes for embedded variable patterns. I only started looking at Zeppelin internals about 10 days back, so your insight will be very helpful.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    I like what you propose, but think it might be very confusing for user if behavior changes depending on whether the variable is in the z context. for instance, it could be a shared notebook and someone might have set `what` and that would changes the outcome of the sql query example you have


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Thank you for the insight. Do you think we may retain variable substitution within literal strings as in the following contrived example?
   
    `%sql select * from spares where part_no = 'pump-{manufacturer-code}'`
   
    Thanks again for your help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    I guess that's tricky.
    like in your example, if it is in `'`, should we leave it alone, or not? `%sql select * from table where name rlike '#{2}'`
   
    I suppose we should first make sure the behavior is consistent in all interpreters and in all/most of token replacement


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Agreed, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Hello @felixcheung @Tagar @zjffdu, this is for any further comments and suggestions. Here are the features implemented:
   
    1. - The substitution pattern is `{ ... }` as suggested for uniformity with Jupyter
    2. - The substitution pattern can be escaped by using `{{ ... }}`, and such patterns are translated into `{ ... }` while retaining the original contents of `{{ ... }}`
    3. - Substitution patterns inside strings (like `'part-{number}'`) are active, and will be substituted. This is also as in the Jupyter feature (@felixcheung this is different from our last exchange)
   
    I have expanded the unit-tests to include these cases, and have added error checks for a variety of ill-formed patterns. The following screenshots show some examples of the feature in use.
   
    ![fig-01](https://user-images.githubusercontent.com/477015/28742890-912ba640-7459-11e7-98dd-8960b2f76a31.png)
    ![fig-02](https://user-images.githubusercontent.com/477015/28742891-912dfc2e-7459-11e7-8a6c-3790de2ef664.png)
    ![fig-03](https://user-images.githubusercontent.com/477015/28742892-9132a9b8-7459-11e7-872d-6c496a98af5c.png)
    ![fig-04](https://user-images.githubusercontent.com/477015/28742893-913749c8-7459-11e7-903b-40b664d1cb2f.png)
   
    Thanks for all your pointers and ideas.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    I think it's fine to replace token within quoted string - this is probably a better, more consistent behavior anyway.
   
    I am concerned with having different ways to replace token in different interpreters though, as pointed out in https://github.com/apache/zeppelin/pull/2502#pullrequestreview-52283678; as adding to that we also have the `${token}` already https://zeppelin.apache.org/docs/0.7.2/manual/dynamicform.html#text-input-form
   
    Can you point me to how this is used in jupyter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Digging a little deeper to clarify the conflict ... The class `BaseZeppelinContext` uses two different key-value repositories for two different needs:
   
    1. **Storage of user-provided inputs entered into dynamic form fields**. These are held in an `AngularObjectRegistry` associated with the particular interpreter in effect, and are managed either (a) programmatically by the functions `z.angularBind(...)` and `z.angularUnbind(...)`, or (b) by using the `${ ... }` notation described at the link you provided (text-input-form) -- this second option is the one that seems to be (but in fact is not) in conflict with the substitution proposal described here.
    2. **Programmatically assigned data intended to be shared across interpreters** (currently Spark, R, and Python). These are held in a `ResourcePool`, and are managed by the functions `z.put(...)`, and `z.get(...)`. This pull request seeks to substitute values from a `ResourcePool` into `{ ... }` patterns in interpreter commands.
   
    So, as described above, these are two different facilities, and use similar but different substitution patterns: the dynamic-forms facility uses `${ ... }` while this pull request (inter-interpreter data sharing facility) proposes to use `{ ... }` and `{{ ... }}` (for escaping the basic substitution pattern).
   
    The Jupyter Python examples quoted are drawn from the context of shell commands spawned by prefixing a command with `!` operator. In this case the { ... } pattern can be used to embed Python snippets (not just a variable name) into the command, and `{{ ... }}` is used for escaping the `{ ... }` substitution pattern.
   
    I hope this clarifies the two patterns and uses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    I can have a go at creating/updating the documentation if someone can help me with any guideance on where/how to begin.
   
    My familiarity with Jupyter is very limited, so while I will dig around, I would also request @Tagar to help if possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user Tagar commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Info from Jupyter comitter @takluyver
   
    > It's fairly brief, but here:
    > http://ipython.readthedocs.io/en/stable/interactive/reference.html#manual-capture-of-command-output-and-magic-output
    >  
    > E.g. found that quoting of curly brackets is done using {{..}} etc.
    > If this documentation doesn't exist (I can't find where this is documented), please point to code
    > that handles this logic.
    >
    > The expansion of variables and expressions is done by the var_expand() method:
    > https://github.com/ipython/ipython/blob/8f50a3771614d3e22505eabc9332d1bc44af6f0e/IPython/core/interactiveshell.py#L3037
    >
    > Running a shell command and capturing the output is the getoutput() method:
    > https://github.com/ipython/ipython/blob/8f50a3771614d3e22505eabc9332d1bc44af6f0e/IPython/core/interactiveshell.py#L2279
    >
    > The escaped double curly braces {{...}} is part of Python's standard string formatting machinery, which we use in var_expand().
    >  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    @felixcheung I have added a couple of paragraphs of documentation including an example showing interaction between the Scala and SQL interpreters to _spark.md_ (at the end of the text under the title [Object Exchange](https://zeppelin.apache.org/docs/0.7.2/interpreter/spark.html#object-exchange) and just above the title [Form Creation](https://zeppelin.apache.org/docs/0.7.2/interpreter/spark.html#form-creation).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Please let me know if there are any further comments or concerns @felixcheung. I have addressed the suggestion on structure of the code in the documentation ([here](https://github.com/apache/zeppelin/pull/2502/files/9b7673b7048992cbd07ccaad300abd16b4021521))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Testing this branch a bit and found there's an edge case with new line
   
    ```
    select
    *
    from {table}
    limit 10
    ````
   
    will throw error
   
    ```
    cannot recognize input near '{' 'table' '}' in join source; line 3 pos 5
    set zeppelin.spark.sql.stacktrace = true to see full stacktrace
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta closed the pull request at:

    https://github.com/apache/zeppelin/pull/2502


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2502: [ZEPPELIN-2807] Passing Z variables to SQL Inte...

asfgit
In reply to this post by asfgit
GitHub user sanjaydasgupta reopened a pull request:

    https://github.com/apache/zeppelin/pull/2502

    [ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967)

   
    ### What is this PR for?
    This feature allows embedding/interpolating Z variables into SQL statements passed to the Spark-SQL interpreter. It implements one part of the functions desired by the pre-existing issue (ZEPPELIN-1967)
   
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2807
   
    ### How should this be tested?
    A new test has been added to the unit tests. The attached screenshot also shows tests of the functionality.
   
    ### Screenshots (if appropriate)
    ![sparksqlchange](https://user-images.githubusercontent.com/477015/28521954-a1148532-7093-11e7-85e8-293d86fb0362.png)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, a small update to any existing documentation is ideal.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaydasgupta/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2502
   
----
commit e8ba58a94743b743f2a05cef8b9755d5bf79510c
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-24T11:29:29Z

    ZEPPELIN-2807: Passing Z variables to SQL Interpreter (One part of ZEPPELIN-1967)

commit 565475d051db7bc30504233a0ca9293c413ca852
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-24T15:06:07Z

    Changed dist to precise in .travis.yml

commit 2b3292a2ed03a50b1ca72400c3c1db277b52c7bf
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-24T15:15:36Z

    Changed dist to precise in .travis.yml - 2nd attempt

commit 149eafa14f2831bfc656b126cb4ea55fbbf55cce
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-25T04:08:58Z

    Corrected regression caused by newly added unit test

commit 47fde2fc6ab9f348d2702293c6ebe0fb389aa252
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-25T07:24:55Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit f098ff111f48d7be04bbbbb6fd6176000f9f4bab
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-26T17:59:45Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit 70fbbc1b5e07ac623dfa1ba873074082d6670562
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-29T04:23:56Z

    Added {{ for escaping single {, and more unit tests for all cases

commit 901098a72560676888537398eb6d4412ca0b6e1f
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-29T05:11:53Z

    Aligned travis.yml with main apache/zeppelin repo

commit 4e0d79e1637c2c9e7e9301ef81f1465b148d26dd
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-07-30T16:29:52Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit 5e0ad610603e010648f89a7e987b713fe95e8705
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-04T16:37:01Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit 28b095222f56772bbffaabed81968e44fb2a0380
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-10T15:40:18Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit 3ca4ba1c2c16cebd884c2bc656932058b585886b
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-11T07:34:03Z

    Aligned travis.yml with main apache/zeppelin repo

commit 861360343e8435b3cd9c3e7ec10a0ac382706f55
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-11T09:31:28Z

    Fixing errors in code-panel display

commit 4f37495c6928044128140f0dd6942aff4500bf2b
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-11T12:57:51Z

    Merge branch 'master' of git://github.com/apache/zeppelin

commit 9b7673b7048992cbd07ccaad300abd16b4021521
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-11T13:51:12Z

    Retrying with restored content

commit d6cbd7205d6721ccff142b82d2e07626c90f8b94
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-12T14:23:18Z

    Changes to comply with review comments (https://github.com/apache/zeppelin/pull/2502/files/9b7673b7048992cbd07ccaad300abd16b4021521)

commit 04acdd854436d5c4a505330b73e444c34e96ab9c
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-12T15:08:53Z

    Switched E2E tests to precise from trusty

commit 906b698187bf5d4f358cb1263bdb15bfb0b286f4
Author: Sanjay Dasgupta <[hidden email]>
Date:   2017-08-12T15:14:35Z

    Revert "Switched E2E tests to precise from trusty" (commit 04acdd8)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

asfgit
In reply to this post by asfgit
Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2502
 
    Thanks for the catch # @Leemoonsoo
   
    I have fixed and committed the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...