[GitHub] zeppelin pull request #2506: Zeppelin 2813

classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2506: Zeppelin 2813

asfgit
GitHub user tinkoff-dwh opened a pull request:

    https://github.com/apache/zeppelin/pull/2506

    Zeppelin 2813

    ### What is this PR for?
    Sometimes need to see the difference between versions and to switch to another version and look for changes are not convenient (the page reloaded). This feature allows you to compare any two versions of the notebook.
   
   
    ### What type of PR is it?
    Feature
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2813
   
    ### How should this be tested?
    1 make some commits. Сchange the contents of paragraphs (delete, add, edit)
    2 open Revisions comparator
    3 compare revisions and check diff
   
    ### Screenshots (if appropriate)
    ![1](https://user-images.githubusercontent.com/25951039/28675980-e11f7134-7302-11e7-961c-f16a17daab62.png)
    ![2](https://user-images.githubusercontent.com/25951039/28675981-e1208772-7302-11e7-93bf-479bc628d103.png)
    ![3](https://user-images.githubusercontent.com/25951039/28675985-e1298002-7302-11e7-8d86-3f5dd0208ddd.png)
    ![4](https://user-images.githubusercontent.com/25951039/28675984-e1254fdc-7302-11e7-8e37-9e9266031e3e.png)
    ![5](https://user-images.githubusercontent.com/25951039/28675982-e123572c-7302-11e7-950e-a1fe2120c510.png)
    ![6](https://user-images.githubusercontent.com/25951039/28675983-e1250aae-7302-11e7-9c48-f2a2644b70fa.png)
    ![7](https://user-images.githubusercontent.com/25951039/28675986-e13c69f6-7302-11e7-8f27-b77a895c413c.png)
    if title exist
    ![8](https://user-images.githubusercontent.com/25951039/28675987-e13d8fc0-7302-11e7-92b8-704af189fdba.png)
   
   
    ### Questions:
    * Does the licenses files need update? yes (updated)
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2813

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2506
   
----
commit a192b95dbb1f8b1cb07123194c77a12c28978eec
Author: Tinkoff DWH <[hidden email]>
Date:   2017-07-27T12:31:07Z

    [ZEPPELIN-2813] revisions comparator for note

commit b9498142b40d80ba07581818011996a66056a9f3
Author: Tinkoff DWH <[hidden email]>
Date:   2017-07-27T14:35:26Z

    [ZEPPELIN-2813] license

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @tinkoff-dwh Do you mind to attach a gif for easy review ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @zjffdu done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    Tested this PR, worked fine. Nice addition 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @felixcheung
    https://github.com/apache/zeppelin/tree/master/docs/quickstart here?
   
    i don't know. I think this is not such a difficult thing to write in documentation...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    +1 to that https://github.com/apache/zeppelin/pull/2506#pullrequestreview-53385386



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    re: doc - I see what you mean. I think it'll be great to have doc on import/export, and this, maybe like https://zeppelin.apache.org/docs/0.7.2/manual/notebookashomepage.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @tinkoff-dwh  It looks great. One suggestion is that is it possible to show the revision comparison inline instead of popping up a new window. Because I think we can some followup work for this feature, like revert to some revision, doing it is inline is more convenient for users.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @zjffdu
    made a separate window because I think that it's more convenient (when a lot of code) and now rewritten for a long time as it is necessary to rewrite all the layout


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @felixcheung @khalidhuseynov
    fixed. added documentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    regarding UX,
   
    - `Choose` box is too big compared to the text inside
    - It would be nice to have the list-like view for each item. For example,
   
    ![image](https://user-images.githubusercontent.com/4968473/28992236-d2836aba-79d1-11e7-8c7f-125dfa80e47e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @1ambda
    fixed
    ![comparator](https://user-images.githubusercontent.com/25951039/29118118-296285a0-7d1a-11e7-9a73-540af586ade4.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh closed the pull request at:

    https://github.com/apache/zeppelin/pull/2506


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
GitHub user tinkoff-dwh reopened a pull request:

    https://github.com/apache/zeppelin/pull/2506

    [ZEPPELIN-2813] revisions comparator

    ### What is this PR for?
    Sometimes need to see the difference between versions and to switch to another version and look for changes are not convenient (the page reloaded). This feature allows you to compare any two versions of the notebook.
   
   
    ### What type of PR is it?
    Feature
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2813
   
    ### How should this be tested?
    1 make some commits. Сchange the contents of paragraphs (delete, add, edit)
    2 open Revisions comparator
    3 compare revisions and check diff
   
    ### Screenshots (if appropriate)
    ![comparator](https://user-images.githubusercontent.com/25951039/28702781-cf1cedce-7378-11e7-9034-7036f4440bf3.gif)
   
   
    ### Questions:
    * Does the licenses files need update? yes (updated)
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2813

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2506
   
----
commit a192b95dbb1f8b1cb07123194c77a12c28978eec
Author: Tinkoff DWH <[hidden email]>
Date:   2017-07-27T12:31:07Z

    [ZEPPELIN-2813] revisions comparator for note

commit b9498142b40d80ba07581818011996a66056a9f3
Author: Tinkoff DWH <[hidden email]>
Date:   2017-07-27T14:35:26Z

    [ZEPPELIN-2813] license

commit 4ce5286c80a5ed022aa7d171f8e1614158d73f1b
Author: tinkoff-dwh <[hidden email]>
Date:   2017-08-01T04:28:27Z

    Merge remote-tracking branch 'origin/master' into ZEPPELIN-2813

commit 514b3f57bce2acfe94965142c9a8d8f357ce2f3f
Author: tinkoff-dwh <[hidden email]>
Date:   2017-08-01T05:42:52Z

    small fixes, added documentation

commit dc67f8fad302b93fbc3de297226695be4e14f294
Author: tinkoff-dwh <[hidden email]>
Date:   2017-08-09T09:43:50Z

    [ZEPPELIN-2813] refactoring

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @tinkoff-dwh Thanks for the update.
   
    In feature and code level, it's good. But personally, I hope we can get improved UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @1ambda
    is it "LGTM" or no?) ' we can get improved UI' sounds unclear)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    I didn't mean both. Just gave an opinion.
    Personally, I don't believe that reviewer only can reply `LGTM` or `NO`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

asfgit
In reply to this post by asfgit
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2506
 
    @1ambda
    I mean, it is not clear what to do, wait for other reviews or to do something (but then it is not clear what)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...