[GitHub] zeppelin pull request #2508: [ZEPPELIN-2817] Support default interpreter set...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2508: [ZEPPELIN-2817] Support default interpreter set...

asfgit
GitHub user reminia opened a pull request:

    https://github.com/apache/zeppelin/pull/2508

    [ZEPPELIN-2817] Support default interpreter setting in create note re…

    …st api
   
    ### What is this PR for?
    Can set default interpreter in create note rest api.
   
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
    None
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2817
   
    ### How should this be tested?
    Post name and interpreter to rest api/notebook, a note with the interpreter should be created.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reminia/zeppelin default-int

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2508
   
----
commit 5b452ba3dde1003f1c5393c493b65be763b9aa61
Author: lichenyang <[hidden email]>
Date:   2017-07-28T09:59:46Z

    [ZEPPELIN-2817] Support default interpreter setting in create note rest api

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2508: [ZEPPELIN-2817] Support default interpreter setting in...

asfgit
Github user reminia commented on the issue:

    https://github.com/apache/zeppelin/pull/2508
 
    Add doc and some modify. @felixcheung @sravan-s , plz help review again.
    Some details:
   
    1. post interpreter name not id, cause name is user friendly and id is something like CRB87NS
    2. if the interpreter name doesnt exist,  return **bad request status** and no note is created.
    3. if successfully created the note, return CREATED status  like the old DOC says.
    4. name/interpreter/paragraphs no need to be supplied together, empty message is also ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2508: [ZEPPELIN-2817] Support default interpreter setting in...

asfgit
In reply to this post by asfgit
Github user reminia commented on the issue:

    https://github.com/apache/zeppelin/pull/2508
 
    @felixcheung @Leemoonsoo  can you help review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2508: [ZEPPELIN-2817] Support default interpreter setting in...

asfgit
In reply to this post by asfgit
Github user reminia commented on the issue:

    https://github.com/apache/zeppelin/pull/2508
 
    Test added @felixcheung


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2508: [ZEPPELIN-2817] Support default interpreter setting in...

asfgit
In reply to this post by asfgit
Github user reminia commented on the issue:

    https://github.com/apache/zeppelin/pull/2508
 
    I decide to leave the api no change at now.  Maybe another jira should be created to address this. I've found that several create operation api doesnt return 201 but 200, such as repo add, paragraph add. @felixcheung @Leemoonsoo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...