[GitHub] zeppelin pull request #2511: Fix Missing import

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: Fix Missing import

asfgit
GitHub user Sdedelbrock opened a pull request:

    https://github.com/apache/zeppelin/pull/2511

    Fix Missing import

    ### What is this PR for?
    The python interpreter has a bug when trying to render matplotlib images from the z.show() function.  Line 139 of `python/src/main/resources/python/zeppelin_python.py` references un-imported package `base64`.  `import base64` was added to the file to prevent this error in the future.
   
   
    ### What type of PR is it?
    Bug Fix
   
    ### Todos
    * [x] - Add missing `base64` module to `python/src/main/resources/python/zeppelin_python.py`
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2821
   
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
   
    ### How should this be tested?
    Display a matplotlib image with zeppelin:
    ```python
    import matplotlib.pyplot as plt
    plt.plot([1,2,3,4])
    z.show(plt)
    ```
   
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sdedelbrock/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2511
   
----
commit 969d82ff97419d928a7a462f2e0c236bf38099b5
Author: Shiem Edelbrock <[hidden email]>
Date:   2017-07-31T20:19:30Z

    Fix Missing import
   
    line 139 references un-imported package `base64`, added import statement

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    could you please setup travis CI to run tests
    https://zeppelin.apache.org/contribution/contributions.html#continuous-integration



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    Thanks @Sdedelbrock for the fix!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    yes, let's get CI to run though :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Sdedelbrock commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    I've force pushed the PR twice to re-trigger the build, and one of the jobs consistently times out.  I have disabled test concurrency to no avail.  I have manually re-run the (failed) test with success, however Jenkins still shows a failure.
   
    Please let me know how you would like me to proceed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    You can close/open this PR to trigger Jenkins. Then Jenkins will check last build result and update this PR build status. Or just leaving message would be okay too, like you just did.
   
    I checked the build result manually https://travis-ci.org/Sdedelbrock/zeppelin/builds/261941334.
   
    LGTM and merge to master and branch-0.7 if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Sdedelbrock closed the pull request at:

    https://github.com/apache/zeppelin/pull/2511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
GitHub user Sdedelbrock reopened a pull request:

    https://github.com/apache/zeppelin/pull/2511

    [ZEPPELIN-2821] Fix Missing import

    ### What is this PR for?
    The python interpreter has a bug when trying to render matplotlib images from the z.show() function.  Line 139 of `python/src/main/resources/python/zeppelin_python.py` references un-imported package `base64`.  `import base64` was added to the file to prevent this error in the future.
   
   
    ### What type of PR is it?
    Bug Fix
   
    ### Todos
    * [x] - Add missing `base64` module to `python/src/main/resources/python/zeppelin_python.py`
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2821
   
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
   
    ### How should this be tested?
    Display a matplotlib image with zeppelin:
    ```python
    import matplotlib.pyplot as plt
    plt.plot([1,2,3,4])
    z.show(plt)
    ```
   
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sdedelbrock/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2511
   
----
commit 2627e709d54c3613d59b5f6d1d127fe0dabdc470
Author: Shiem Edelbrock <[hidden email]>
Date:   2017-07-31T20:19:30Z

    Fix Missing import
   
    line 139 references un-imported package `base64`, added import statement

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Sdedelbrock closed the pull request at:

    https://github.com/apache/zeppelin/pull/2511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
GitHub user Sdedelbrock reopened a pull request:

    https://github.com/apache/zeppelin/pull/2511

    [ZEPPELIN-2821] Fix Missing import

    ### What is this PR for?
    The python interpreter has a bug when trying to render matplotlib images from the z.show() function.  Line 139 of `python/src/main/resources/python/zeppelin_python.py` references un-imported package `base64`.  `import base64` was added to the file to prevent this error in the future.
   
   
    ### What type of PR is it?
    Bug Fix
   
    ### Todos
    * [x] - Add missing `base64` module to `python/src/main/resources/python/zeppelin_python.py`
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2821
   
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
   
    ### How should this be tested?
    Display a matplotlib image with zeppelin:
    ```python
    import matplotlib.pyplot as plt
    plt.plot([1,2,3,4])
    z.show(plt)
    ```
   
    ### Questions:
    * Does the licenses files need update?
    no
    * Is there breaking changes for older versions?
    no
    * Does this needs documentation?
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sdedelbrock/zeppelin patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2511
   
----
commit 2627e709d54c3613d59b5f6d1d127fe0dabdc470
Author: Shiem Edelbrock <[hidden email]>
Date:   2017-07-31T20:19:30Z

    Fix Missing import
   
    line 139 references un-imported package `base64`, added import statement

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user Sdedelbrock commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    it.....
    finally......
    happened!
    😄


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2511
 
    awesome!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2511: [ZEPPELIN-2821] Fix Missing import

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2511


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...