[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...

asfgit
GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/2514

    replace pegdown to markdown zeppelin interpreter

    ### What is this PR for?
    I was change markdown render librarry for Jupyter note convertor.
    currently, we can got a same result for markdown.
   
    ### What type of PR is it?
    Improvement
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2824
   
    ### How should this be tested?
    1. build jupyter module
      `mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
    2. `cd zeppelin-jupyter/target`
    3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file path!/getting_started.ipynb`
        (good sample : [go to sample](https://github.com/SciRuby/sciruby-notebooks/blob/master/getting_started.ipynb)
    4. get a `note.json` and import to zeppelin on frontend!
    5. enjoy
    ### Screenshots (if appropriate)
   
    #### problem
    ![28689484-9b13f3d2-72ca-11e7-9bda-02d33b30f036](https://user-images.githubusercontent.com/10525473/28861908-0d05c592-779e-11e7-9a4e-94e3fd2bd176.png)
   
    #### after
    ![image](https://user-images.githubusercontent.com/10525473/28807730-029510e6-76b2-11e7-9111-0e18569b1630.png)
   
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2824-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2514
   
----
commit 2e8b3326b6fe3fb017f78cdfd6cecf1135484706
Author: CloverHearts <[hidden email]>
Date:   2017-08-02T07:12:45Z

    replace pegdown to markdown zeppelin interpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    @cloverhearts Thanks the the improvement!
   
    @felixcheung I think title of this PR little bit misleading. This does not change parser of existing markdown interpreter, but change Jupyter notebook converter use Zeppelin-Interpreter module to parse markdown, instead of directly call pegdown parser.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    ah yes, jupyter converter doesn't have doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    Is there any plan to integrate jupyter converter into zeppelin UI (like import from jupyter note) ? Otherwise I will doubt how many people will use this feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    BTW, it seems pegdown is duplicated according its official github repo. https://github.com/sirthias/pegdown
    We need to switch to flexmark-java which pegdown suggests for users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    > Is there any plan to integrate jupyter converter into zeppelin UI (like import from jupyter note) ? Otherwise I will doubt how many people will use this feature.
   
    Right, this can be the next step
   
    > BTW, it seems pegdown is duplicated according its official github repo. https://github.com/sirthias/pegdown
   
    Good to know!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    @cloverhearts Test fails with
   
    ```
    Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.714 sec <<< FAILURE! - in org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest
    getNoteAndVerifyData(org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest)  Time elapsed: 0.141 sec  <<< FAILURE!
    java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertTrue(Assert.java:52)
    at org.apache.zeppelin.jupyter.nbformat.JupyterUtilTest.getNoteAndVerifyData(JupyterUtilTest.java:89)
   
   
    Results :
   
    Failed tests:
      JupyterUtilTest.getNoteAndVerifyData:89 null
   
    Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
    ```
   
    Could you take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    Sorry for the delay.
    @Leemoonsoo I will fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    https://travis-ci.org/cloverhearts/zeppelin
   
    ci pass :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2514
 
    CI went green https://travis-ci.org/cloverhearts/zeppelin/builds/262539649.
    LGTM and merge to master if no further comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...