[GitHub] zeppelin pull request #2518: Fixing zeppelin-2281 by clearing output when da...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2518: Fixing zeppelin-2281 by clearing output when da...

asfgit
GitHub user SachinJanani opened a pull request:

    https://github.com/apache/zeppelin/pull/2518

    Fixing zeppelin-2281 by clearing output when data is available

    ### What is this PR for?
    Fixing ZEPPELIN-2281 by clearing previous when new data is available
   
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2281
   
    ### How should this be tested?
    * Execute a paragraph and see the output
    * Execute the same paragraph again but abort it before completion and see the output.Paragraph is clear and previous output is lost
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update?    NA
    * Is there breaking changes for older versions? NA
    * Does this needs documentation? NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SachinJanani/zeppelin ZEPPELIN-2281

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2518
   
----
commit 64e1c0e5ead6f765f36abeb05f2188c87ce5bd04
Author: Sachin <[hidden email]>
Date:   2017-08-07T04:42:03Z

    Fixing zeppelin-2281 by clearing output when data is available

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    Thanks @SachinJanani for contribution.
    Could you try setup CI and see it this PR passes the CI build?
   
    ```
    Looks like travis-ci is not configured for your fork.
    Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.
    And then make sure 'Build branch updates' option is enabled in the settings https://travis-ci.org/SachinJanani/zeppelin/settings.
   
    To trigger CI after setup, you will need ammend your last commit with
    git commit --amend
    git push your-remote HEAD --force
   
    See http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user SachinJanani commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    @Leemoonsoo  Thanks for the review.Have started the travis build. @felixcheung With this change it will not clear the output if the execution fails and keep the previous output.But if there any exception then it will print them


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user SachinJanani commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    This build is failing due to some environment issue in jenkins can someone please help me out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    Not sure why CI is failing. @SachinJanani Have you tried restart failed job?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user SachinJanani commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    Yes @Leemoonsoo I have tried restarting failed job but it didn't succeed :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user SachinJanani commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    @Leemoonsoo  Merging the upstream and restarting the travis build did the trick.Here is the travis link for this PR-https://travis-ci.org/SachinJanani/zeppelin/builds/265444667.Can you please merge this PR if there are no more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2518: Fixing zeppelin-2281 by clearing output when data is a...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2518
 
    Thanks @SachinJanani for the fix!
   
    Merge to master and branch-0.7 if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2518: Fixing zeppelin-2281 by clearing output when da...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...