[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

asfgit
GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2524

    [ZEPPELIN-2846] Add selenium test case for AnyOfRolesAuthorizationFilter

    ### What is this PR for?
    This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter)
   
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
    * [ZEPPELIN-2846](https://issues.apache.org/jira/browse/ZEPPELIN-2846)
   
    ### How should this be tested?
    CI should be green
   
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2524
   
----
commit e2a7ad548516a91c774afeb80d905859c47f8983
Author: Prabhjyot Singh <[hidden email]>
Date:   2017-08-10T23:27:28Z

    add selenium test case for AnyOfRolesAuthorizationFilter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

asfgit
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2524
 
    Ready for review, https://travis-ci.org/prabhjyotsingh/zeppelin/builds/263300475. 439.2 Failed which is unrelated (have restarted it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

asfgit
In reply to this post by asfgit
Github user prabhjyotsingh closed the pull request at:

    https://github.com/apache/zeppelin/pull/2524


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

asfgit
In reply to this post by asfgit
GitHub user prabhjyotsingh reopened a pull request:

    https://github.com/apache/zeppelin/pull/2524

    [ZEPPELIN-2846] Add selenium test case for AnyOfRolesAuthorizationFilter

    ### What is this PR for?
    This is to test the new feature that was brought in with ZEPPELIN-2825 (org.apache.zeppelin.utils.AnyOfRolesAuthorizationFilter)
   
   
    ### What type of PR is it?
    [Improvement]
   
    ### What is the Jira issue?
    * [ZEPPELIN-2846](https://issues.apache.org/jira/browse/ZEPPELIN-2846)
   
    ### How should this be tested?
    CI should be green
   
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2846

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2524.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2524
   
----
commit e2a7ad548516a91c774afeb80d905859c47f8983
Author: Prabhjyot Singh <[hidden email]>
Date:   2017-08-10T23:27:28Z

    add selenium test case for AnyOfRolesAuthorizationFilter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

asfgit
In reply to this post by asfgit
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2524
 
    @1ambda @Leemoonsoo @VipinRathor Please help review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

asfgit
In reply to this post by asfgit
Github user VipinRathor commented on the issue:

    https://github.com/apache/zeppelin/pull/2524
 
    Reviewed. Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2524
 
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2524: [ZEPPELIN-2846] Add selenium test case for AnyOfRolesA...

asfgit
In reply to this post by asfgit
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2524
 
    Thanks for the review will merge this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2524: [ZEPPELIN-2846] Add selenium test case for AnyO...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2524


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...