[GitHub] zeppelin pull request #2525: Make admin role to bypass auth logic

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2525: Make admin role to bypass auth logic

asfgit
GitHub user yu74n opened a pull request:

    https://github.com/apache/zeppelin/pull/2525

    Make admin role to bypass auth logic

    ### What is this PR for?
    For administrator, make new admin role that assigned user can see all notebooks.
   
    ### What type of PR is it?
    Improvement
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2647
   
    ### How should this be tested?
    1. Change Notebook workspace to private through whether ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
    2. Set role name to use as admin through ZEPPELIN_OWNER_ROLE = <role name> or zeppelin.owner.role = <role name>.
    Default role name is admin
    3. Login as user who is not assigned as admin and create notebook.
    4. Logout the user and login another user who is assigned as admin, open the created notebook.
   
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? Y/N
    * Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yu74n/zeppelin admin-role

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2525
   
----
commit e79260c1cae85dd5a740fb457b43efa88a981816
Author: Yuta Hongo <[hidden email]>
Date:   2017-08-10T01:38:01Z

    Make admin role to bypass auth logic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2525: Make admin role to bypass auth logic

asfgit
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2525
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

asfgit
In reply to this post by asfgit
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2525
 
    I think so. If we add admin when creating, it would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2525
 
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...