[GitHub] zeppelin pull request #2526: Added new type of user

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin pull request #2526: Added new type of user

asfgit
GitHub user gfalcone opened a pull request:

    https://github.com/apache/zeppelin/pull/2526

    Added new type of user

    ### What is this PR for?
   
    The idea of this PR is to provide a new kind of user : Runner.
   
    Basically, what it does is that it just removes write authorization and allow user to read and run note.
   
    ### What type of PR is it?
    [Feature]
   
    ### Todos
    * [ ] - Task
   
    ### What is the Jira issue?
    [ZEPPELIN-2848] https://issues.apache.org/jira/browse/ZEPPELIN-2848
   
    ### How should this be tested?
    - Log in as admin
    - Create new notebook and create a paragraph with the interpreter you want
    - Assign runner right to user1
    - Log in as user1
    - Try to run the paragraph (should work)
    - Try to modify the paragraph (should fail)
    - Log in as user2
    - Try to run the paragraph (should fail)
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? Yes
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gfalcone/zeppelin new_type_runner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2526
   
----
commit 5c43ca957a9ac1c4875289e5337f4229c5853a47
Author: Paolo Genissel <[hidden email]>
Date:   2017-08-11T17:20:03Z

    Added new type of user

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: Added new type of user

asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    Hi,
   
    Thanks for reviewing my PR.
   
    Actually readers cannot run the notebook.
   
    So what runners have read access + the ability to run the notebook


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: Added new type of user

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung runners have execute rights then in the Unix sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung CI passed https://travis-ci.org/gfalcone/zeppelin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    I saw that people were asking there is this kind of permission.
   
    - https://stackoverflow.com/questions/43971836/how-do-i-set-permissions-to-a-zeppelin-note-to-be-able-to-execute-but-not-change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @1ambda yes this PR totally address this problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung CI ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    Can Readers here Run as well, so it's a bit different from the Linux permission model. Can Runners Read?
   
    I am not sure if we should change the existing Readers role and it's semantics though. Would love to see how other think about this.
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung no readers cannot run, that's why I made a new type of user to enable the possibility of running a notebook without modifying its content.
   
    This feature also avoids changing rights to readers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    I see. In the case someone is upgrading from the current version of Zeppelin with an existing notebook with Readers role set, would they run into trouble that those users can no longer run the notebook?
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung nothing would change for them because readers cannot run the notebook. The only rights allowed to run a notebook are writers and owners


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    ok, sorry for dragging it on... then I'll flip the question, are Writers also Runners then?
    In the case someone is upgrading from the current version of Zeppelin with an existing notebook with ~~Readers~~ Writers role set, would they run into trouble that those users can no longer run the notebook?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user gfalcone commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    @felixcheung no problem :), so yes writers can run in the current version, but since I didn't want to modify how writers and readers behave, I created an in-between user


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    I see, so to summarize, before:
    ```
    Readers
    Writers
    Owners
    ```
   
    After
    ```
    Readers
    Writers
    Runners
    Owners
    ```
    where Writers are also Runners
   
    I think it'll be great to get some community feedback on whether this is a good model to go forward.
    Open to others to comment?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

asfgit
In reply to this post by asfgit
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2526
 
    Tested this branch and it works well.
   
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...