[GitHub] zeppelin pull request #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cann...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cann...

anthonycorbacho
GitHub user buxiaoliang opened a pull request:

    https://github.com/apache/zeppelin/pull/2670

    [ZEPPELIN-3052] Chrome console: TypeError: Cannot set property 'principal' of undefined

    ### What is this PR for?
    To fix console error when user logout after Apache Shiro enabled.
   
   
    ### What type of PR is it?
    [Bug Fix]
   
   
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3052
   
    ### Screenshots
    ![image](https://user-images.githubusercontent.com/11644623/32828564-6754c6cc-ca2a-11e7-9020-52a0e8817741.png)
   
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/buxiaoliang/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2670
   
----
commit 850c2fd259090dd9489d3602ad51aba276c24d19
Author: bur <[hidden email]>
Date:   2017-11-15T09:19:15Z

    [ZEPPELIN-3052] Chrome console: TypeError: Cannot set property 'principal' of undefined

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cannot set ...

anthonycorbacho
Github user buxiaoliang commented on the issue:

    https://github.com/apache/zeppelin/pull/2670
 
    OK. Thanks for review. I kick off the test again but seems the error is not related to my change.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cannot set ...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2670
 
    that's odd, anyone knows what's wrong with the build profile?
    ```
    All tests passed.
    [WARNING] The requested profile "web-ci" could not be activated because it does not exist.
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.16:verify (default) on project zeppelin-server: There are test failures.
    [ERROR]
    [ERROR] Please refer to /home/travis/build/buxiaoliang/zeppelin/zeppelin-server/target/failsafe-reports for the individual test results.
    [ERROR] -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    [ERROR]
    [ERROR] After correcting the problems, you can resume the build with the command
    [ERROR]   mvn <goals> -rf :zeppelin-server
    The command "mvn $TEST_FLAG $MODULES $PROFILE -B $TEST_PROJECTS" exited with 1.
    ```


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cannot set ...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user buxiaoliang commented on the issue:

    https://github.com/apache/zeppelin/pull/2670
 
    03:38:11,387  INFO org.apache.zeppelin.CommandExecutor:46 - Sending command "bash -c ../bin/zeppelin-daemon.sh restart" to localhost
    Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 151.973 sec <<< FAILURE! - in org.apache.zeppelin.integration.PersonalizeActionsIT
    testGraphAction(org.apache.zeppelin.integration.PersonalizeActionsIT)  Time elapsed: 52.675 sec  <<< FAILURE!
    java.lang.AssertionError: The output of graph mode is not changed
    Expected: "fa fa-bar-chart"
         but: was "fa fa-table"
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    at org.junit.Assert.assertThat(Assert.java:956)
    at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    at org.apache.zeppelin.integration.PersonalizeActionsIT.testGraphAction(PersonalizeActionsIT.java:263)
    testDynamicFormAction(org.apache.zeppelin.integration.PersonalizeActionsIT)  Time elapsed: 20.589 sec  <<< FAILURE!
    java.lang.AssertionError: The output of graph mode is changed
    Expected: "Status: Before"
         but: was "Status: After"
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    at org.junit.Assert.assertThat(Assert.java:956)
    at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
    at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
    at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
    at org.apache.zeppelin.integration.PersonalizeActionsIT.testDynamicFormAction(PersonalizeActionsIT.java:345)
    There is test failed but I don't know why. Anyone can help?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cann...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2670


---