[GitHub] zeppelin pull request #2680: [ZEPPELIN-3066] Make the welcome header of the ...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2680: [ZEPPELIN-3066] Make the welcome header of the ...

asfgit
GitHub user kjmrknsn opened a pull request:

    https://github.com/apache/zeppelin/pull/2680

    [ZEPPELIN-3066] Make the welcome header of the homepage for non login users customizable

    ### What is this PR for?
    Make the welcome header of the homepage for non login users customizable.
   
    In our company's use case, we would like to customize the contents of the welcome header of the homepage for non login users so that we can introduce how to create an LDAP account to login Zeppelin to them.
   
    ### What type of PR is it?
    [Improvement]
   
    ### Todos
   
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3066
   
   
    ### How should this be tested?
    * Tested manually.
        * I confirmed that the content of the HTML file whose path was set by `zeppelin.homescreen.header` was shown on the top of the home screen page.
            * <img width="986" alt="screen shot 2017-11-20 at 18 13 33" src="https://user-images.githubusercontent.com/31149688/33010922-953cec1a-ce1f-11e7-9aad-b7f953736036.png">
        * I also confirmed that if `zeppelin.homescreen.header` was not set, the default contents (`app/home/header.html`) was shown.
            * <img width="984" alt="screen shot 2017-11-20 at 18 14 30" src="https://user-images.githubusercontent.com/31149688/33010954-b59f5b64-ce1f-11e7-9b1b-481ee9ba207f.png">
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No.
    * Is there breaking changes for older versions? No.
    * Does this needs documentation? Yes. `docs/setup/operation/configuration.md` was updated.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3066

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2680
   
----
commit 3bc91488587152041bb2185c36682994a51a582f
Author: Keiji Yoshida <[hidden email]>
Date:   2017-11-20T04:58:39Z

    [ZEPPELIN-3066] Make the welcome header of the homepage for non login users customizable

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2680: [ZEPPELIN-3066] Make the welcome header of the ...

asfgit
Github user kjmrknsn closed the pull request at:

    https://github.com/apache/zeppelin/pull/2680


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2680: [ZEPPELIN-3066] Make the welcome header of the homepag...

asfgit
In reply to this post by asfgit
Github user kjmrknsn commented on the issue:

    https://github.com/apache/zeppelin/pull/2680
 
    This PR is replaced with https://github.com/apache/zeppelin/pull/2682.


---