[GitHub] zeppelin pull request #2681: [ZEPPELIN-2995] "auto-restart interpreter on cr...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2681: [ZEPPELIN-2995] "auto-restart interpreter on cr...

anthonycorbacho
GitHub user kjmrknsn opened a pull request:

    https://github.com/apache/zeppelin/pull/2681

    [ZEPPELIN-2995] "auto-restart interpreter on cron execution" should restart interpreter to specific note, not all interpreters

    ### What is this PR for?
    Make "auto-restart interpreter on cron execution" restart interpreter to specific note, not all interpreters.
    This issue was reported by https://github.com/apache/zeppelin/pull/1302#issuecomment-336521420.
   
    ### What type of PR is it?
    [Bug Fix]
   
    ### Todos
   
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2995
   
    ### How should this be tested?
    * Tested Manually.
       * I confirmed that the "auto-restart interpreter on cron execution" feature restarted only the interpreters which are specific to the notebook.
   
    ### Screenshots (if appropriate)
   
    ### Questions:
    * Does the licenses files need update? No.
    * Is there breaking changes for older versions? No.
    * Does this needs documentation? No.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-2995

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2681
   
----
commit f7b528d390f4464e8011d22d9bed60e0ff176a09
Author: Keiji Yoshida <[hidden email]>
Date:   2017-11-20T13:54:39Z

    [ZEPPELIN-2995] "auto-restart interpreter on cron execution" should restart interpreter to specific note, not all interpreters

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

anthonycorbacho
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2681
 
    Thanks @kjmrknsn for the fix. It looks great to me!
   
    If we can add a automated test, like [testAutoRestartInterpreterAfterSchedule ](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java#L405), it'll help make sure any future change doesn't break this behavior.
   
    Do you think you can add a test? Let me know if you need help on adding test!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user kjmrknsn commented on the issue:

    https://github.com/apache/zeppelin/pull/2681
 
    @Leemoonsoo I'll try to add a test. Thanks.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user kjmrknsn commented on the issue:

    https://github.com/apache/zeppelin/pull/2681
 
    @Leemoonsoo The unit test was added to `NotebookTest.java`. Thanks.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin issue #2681: [ZEPPELIN-2995] "auto-restart interpreter on cron exec...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2681
 
    Thanks @kjmrknsn for adding test!
    LGTM and merge to master if no further reviews.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] zeppelin pull request #2681: [ZEPPELIN-2995] "auto-restart interpreter on cr...

anthonycorbacho
In reply to this post by anthonycorbacho
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2681


---